From: arun.ramamurthy@broadcom.com (Arun Ramamurthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Date: Fri, 20 Mar 2015 14:07:09 -0700 [thread overview]
Message-ID: <1426885630-32429-3-git-send-email-arun.ramamurthy@broadcom.com> (raw)
In-Reply-To: <1426885630-32429-1-git-send-email-arun.ramamurthy@broadcom.com>
Getting phys by index instead of phy names so that the dt
bindings phy-names remain consistent when multiple phys are present
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
---
drivers/usb/host/ehci-platform.c | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index d8a75a5..8b0c7ae 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -154,7 +154,6 @@ static int ehci_platform_probe(struct platform_device *dev)
struct usb_ehci_pdata *pdata = dev_get_platdata(&dev->dev);
struct ehci_platform_priv *priv;
struct ehci_hcd *ehci;
- const char *phy_name;
int err, irq, phy_num, clk = 0;
if (usb_disabled())
@@ -212,21 +211,10 @@ static int ehci_platform_probe(struct platform_device *dev)
return -ENOMEM;
for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
- err = of_property_read_string_index(
- dev->dev.of_node,
- "phy-names", phy_num,
- &phy_name);
-
- if (err < 0) {
- if (priv->num_phys > 1) {
- dev_err(&dev->dev, "phy-names not provided");
- goto err_put_hcd;
- } else
- phy_name = "usb";
- }
-
- priv->phys[phy_num] = devm_phy_get(&dev->dev,
- phy_name);
+ priv->phys[phy_num] =
+ devm_of_phy_get_by_index(&dev->dev,
+ dev->dev.of_node,
+ phy_num);
if (IS_ERR(priv->phys[phy_num])) {
err = PTR_ERR(priv->phys[phy_num]);
if ((priv->num_phys > 1) ||
--
2.3.2
next prev parent reply other threads:[~2015-03-20 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 21:07 [PATCH 0/3] Add devm_of_phy_get_by_index and update platform drivers Arun Ramamurthy
2015-03-20 21:07 ` [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core Arun Ramamurthy
2015-03-20 21:26 ` Dmitry Torokhov
2015-03-20 21:29 ` Arun Ramamurthy
2015-03-25 22:03 ` Kishon Vijay Abraham I
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 23:07 ` Dmitry Torokhov
2015-03-31 16:00 ` Kishon Vijay Abraham I
2015-03-20 21:07 ` Arun Ramamurthy [this message]
2015-03-20 21:40 ` [PATCH 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index Dmitry Torokhov
2015-03-20 21:07 ` [PATCH 3/3] usb: ohci-platform: " Arun Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426885630-32429-3-git-send-email-arun.ramamurthy@broadcom.com \
--to=arun.ramamurthy@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).