linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arun.ramamurthy@broadcom.com (Arun Ramamurthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level
Date: Fri, 20 Mar 2015 14:25:25 -0700	[thread overview]
Message-ID: <1426886727-537-2-git-send-email-arun.ramamurthy@broadcom.com> (raw)
In-Reply-To: <1426886727-537-1-git-send-email-arun.ramamurthy@broadcom.com>

Multi-port phy's may have per-port power supplies. Let's change phy core
to first attempt to look up the supply at the port level, and then, if
not found, check parent device.

Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
---
 drivers/phy/phy-core.c | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index a12d353..b43bb6b 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -650,16 +650,6 @@ struct phy *phy_create(struct device *dev, struct device_node *node,
 		goto free_phy;
 	}
 
-	/* phy-supply */
-	phy->pwr = regulator_get_optional(dev, "phy");
-	if (IS_ERR(phy->pwr)) {
-		if (PTR_ERR(phy->pwr) == -EPROBE_DEFER) {
-			ret = -EPROBE_DEFER;
-			goto free_ida;
-		}
-		phy->pwr = NULL;
-	}
-
 	device_initialize(&phy->dev);
 	mutex_init(&phy->mutex);
 
@@ -673,6 +663,26 @@ struct phy *phy_create(struct device *dev, struct device_node *node,
 	if (ret)
 		goto put_dev;
 
+	/*
+	 * Locate phy-supply. We first try individual port and then,
+	 * if supply is not found, try parent device.
+	 */
+	phy->pwr = regulator_get_optional(&phy->dev, "phy");
+	if (IS_ERR(phy->pwr)) {
+		ret = PTR_ERR(phy->pwr);
+		if (ret == -EPROBE_DEFER)
+			goto free_ida;
+
+		phy->pwr = regulator_get_optional(phy->dev.parent, "phy");
+		if (IS_ERR(phy->pwr)) {
+			ret = PTR_ERR(phy->pwr);
+			if (ret == -EPROBE_DEFER)
+				goto free_ida;
+
+			phy->pwr = NULL;
+		}
+	}
+
 	ret = device_add(&phy->dev);
 	if (ret)
 		goto put_dev;
-- 
2.3.2

  reply	other threads:[~2015-03-20 21:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 21:25 [PATCH v1 0/3] USB PHY driver for Broadcom's Cygnus chipse Arun Ramamurthy
2015-03-20 21:25 ` Arun Ramamurthy [this message]
2015-03-20 21:31   ` [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level Dmitry Torokhov
2015-03-25 22:11   ` Kishon Vijay Abraham I
2015-03-25 22:17     ` Dmitry Torokhov
2015-03-25 22:39       ` Kishon Vijay Abraham I
2015-03-25 22:49         ` Dmitry Torokhov
2015-03-25 23:44           ` Kishon Vijay Abraham I
2015-03-25 23:48             ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 2/3] Phy: DT binding documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
2015-03-25 22:16   ` Kishon Vijay Abraham I
2015-03-26  0:04     ` Arun Ramamurthy
2015-03-26 23:02       ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver Arun Ramamurthy
2015-03-25 22:28   ` Kishon Vijay Abraham I
2015-03-25 22:42     ` Dmitry Torokhov
2015-03-26  0:01       ` Kishon Vijay Abraham I
2015-03-26  0:06         ` Arun Ramamurthy
2015-03-31  6:16           ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426886727-537-2-git-send-email-arun.ramamurthy@broadcom.com \
    --to=arun.ramamurthy@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).