* [PATCH] sun4i-timer: Only register a sched_clock on sun4i and sun5i
@ 2015-03-21 14:45 Hans de Goede
2015-03-22 15:44 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2015-03-21 14:45 UTC (permalink / raw)
To: linux-arm-kernel
sun6i and newer have an arm arch timer which is a better sched_clock source
then the sun4i-timer, and sched_clock does not have priorities, so do not
register the sun4i-timer sched_clock at all on sun6i and newer.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/clocksource/sun4i_timer.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c
index f4a9c00..1928a89 100644
--- a/drivers/clocksource/sun4i_timer.c
+++ b/drivers/clocksource/sun4i_timer.c
@@ -170,7 +170,15 @@ static void __init sun4i_timer_init(struct device_node *node)
TIMER_CTL_CLK_SRC(TIMER_CTL_CLK_SRC_OSC24M),
timer_base + TIMER_CTL_REG(1));
- sched_clock_register(sun4i_timer_sched_read, 32, rate);
+ /*
+ * sched_clock_register does not have priorities, and on sun6i and
+ * later there is a better sched_clock registered by arm_arch_timer.c
+ */
+ if (of_machine_is_compatible("allwinner,sun4i-a10") ||
+ of_machine_is_compatible("allwinner,sun5i-a13") ||
+ of_machine_is_compatible("allwinner,sun5i-a10s"))
+ sched_clock_register(sun4i_timer_sched_read, 32, rate);
+
clocksource_mmio_init(timer_base + TIMER_CNTVAL_REG(1), node->name,
rate, 350, 32, clocksource_mmio_readl_down);
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] sun4i-timer: Only register a sched_clock on sun4i and sun5i
2015-03-21 14:45 [PATCH] sun4i-timer: Only register a sched_clock on sun4i and sun5i Hans de Goede
@ 2015-03-22 15:44 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2015-03-22 15:44 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 21, 2015 at 03:45:57PM +0100, Hans de Goede wrote:
> sun6i and newer have an arm arch timer which is a better sched_clock source
> then the sun4i-timer, and sched_clock does not have priorities, so do not
> register the sun4i-timer sched_clock at all on sun6i and newer.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150322/e58e7b16/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-22 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-21 14:45 [PATCH] sun4i-timer: Only register a sched_clock on sun4i and sun5i Hans de Goede
2015-03-22 15:44 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).