From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] clocksource: dw_apb_timer_of: make IO endian agnostic
Date: Wed, 25 Mar 2015 11:23:27 +0000 [thread overview]
Message-ID: <1427282610-10350-5-git-send-email-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <1427282610-10350-1-git-send-email-ben.dooks@codethink.co.uk>
The dw_apb_timer_of timer is using __raw_readl to access the timer
register, which is causing issues when the system is running in
big endian mode. Fix this by using readl_relaxed() which should
account for the endian settings.
This fixes issues where the time jumps around in the dmesg output
due to returnling __le32 values.
For an example, these two console lines show time running backwards:
[ 49.882572] CPU1: failed to come online
[ 43.282457] Brought up 1 CPUs
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
--
CC: Daniel Lezcano <daniel.lezcano@linaro.org>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>
CC: Dinh Nguyen <dinguyen@opensource.altera.com>
---
drivers/clocksource/dw_apb_timer_of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
index d305fb0..a19a3f6 100644
--- a/drivers/clocksource/dw_apb_timer_of.c
+++ b/drivers/clocksource/dw_apb_timer_of.c
@@ -108,7 +108,7 @@ static void __init add_clocksource(struct device_node *source_timer)
static u64 notrace read_sched_clock(void)
{
- return ~__raw_readl(sched_io_base);
+ return ~readl_relaxed(sched_io_base);
}
static const struct of_device_id sptimer_ids[] __initconst = {
--
2.1.4
next prev parent reply other threads:[~2015-03-25 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1427282610-10350-1-git-send-email-ben.dooks@codethink.co.uk>
2015-03-25 11:23 ` [PATCH 2/7] ARM: socfpga: enable big endian for secondary core(s) Ben Dooks
2015-03-25 11:23 ` [PATCH 3/7] ARM: socfpga: support big endian for socfpga Ben Dooks
2015-03-25 11:23 ` Ben Dooks [this message]
2015-03-26 9:43 ` [PATCH 4/7] clocksource: dw_apb_timer_of: make IO endian agnostic Daniel Lezcano
2015-03-26 10:56 ` Ben Dooks
2015-03-26 10:58 ` Daniel Lezcano
2015-03-25 11:23 ` [PATCH 5/7] mmc: host: dw_mmc make IO accessors " Ben Dooks
2015-03-25 11:23 ` [PATCH 6/7] mmc: host: dw_mmc: change idmac descriptor files to __le32 Ben Dooks
2015-03-25 11:23 ` [PATCH 7/7] mmc: host: dw_mmc: fix fifo ordering in big endian Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427282610-10350-5-git-send-email-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).