From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: at_hdmac: use __le32 for dma addresses
Date: Thu, 26 Mar 2015 18:02:09 +0000 [thread overview]
Message-ID: <1427392929-10578-1-git-send-email-ben.dooks@codethink.co.uk> (raw)
The at_dmac uses a lli structure with a mix of dma_addr_t and
__le32 in it. As Russell King pointed out, dma_addr_t could be
a non 32-bit size depending on the kernel configuration. Change
all references of this to __le32 to better match the hardware
representation.
Note, this does nothing to fix the discussion of dma vs physical
addresses also brought up during these discussions.
This patch depends on the __le32 descriptor updates posted
previously.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
--
CC: Russell King <linux@arm.linux.org.uk>
CC: Nicolas Ferre <nicolas.ferre@atmel.com>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Vinod Koul <vinod.koul@intel.com>
CC: linux-arm-kernel at lists.infradead.org
CC: dmaengine at vger.kernel.org
---
drivers/dma/at_hdmac_regs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index bd4d174..b246beb 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -167,13 +167,13 @@
/* LLI == Linked List Item; aka DMA buffer descriptor */
struct at_lli {
/* values that are not changed by hardware */
- dma_addr_t saddr;
- dma_addr_t daddr;
+ __le32 saddr;
+ __le32 daddr;
/* value that may get written back: */
__le32 ctrla;
/* more values that are not changed by hardware */
__le32 ctrlb;
- dma_addr_t dscr; /* chain to next lli */
+ __le32 dscr; /* chain to next lli */
};
/**
--
2.1.4
next reply other threads:[~2015-03-26 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 18:02 Ben Dooks [this message]
2015-04-02 7:43 ` [PATCH] dma: at_hdmac: use __le32 for dma addresses Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427392929-10578-1-git-send-email-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).