From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kvm: round HYP section to page size instead of log2 upper bound
Date: Fri, 27 Mar 2015 11:18:01 +0100 [thread overview]
Message-ID: <1427451481-16053-2-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1427451481-16053-1-git-send-email-ard.biesheuvel@linaro.org>
Older binutils do not support expressions involving the values of
external symbols so just round up the HYP region to the page size.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/arm/kernel/vmlinux.lds.S | 31 +------------------------------
arch/arm/kvm/init.S | 3 ---
2 files changed, 1 insertion(+), 33 deletions(-)
diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S
index 808398ec024e..f2db429ea75d 100644
--- a/arch/arm/kernel/vmlinux.lds.S
+++ b/arch/arm/kernel/vmlinux.lds.S
@@ -12,26 +12,6 @@
#include <asm/pgtable.h>
#endif
-/*
- * Poor man's version of LOG2CEIL(), which is
- * not available in binutils before v2.24.
- */
-#define LOG2_ROUNDUP(size) ( \
- __LOG2_ROUNDUP(size, 2) \
- __LOG2_ROUNDUP(size, 3) \
- __LOG2_ROUNDUP(size, 4) \
- __LOG2_ROUNDUP(size, 5) \
- __LOG2_ROUNDUP(size, 6) \
- __LOG2_ROUNDUP(size, 7) \
- __LOG2_ROUNDUP(size, 8) \
- __LOG2_ROUNDUP(size, 9) \
- __LOG2_ROUNDUP(size, 10) \
- __LOG2_ROUNDUP(size, 11) \
- 12)
-
-#define __LOG2_ROUNDUP(size, order) \
- (size) <= (1 << order) ? order :
-
#define PROC_INFO \
. = ALIGN(4); \
VMLINUX_SYMBOL(__proc_info_begin) = .; \
@@ -43,20 +23,11 @@
VMLINUX_SYMBOL(__idmap_text_start) = .; \
*(.idmap.text) \
VMLINUX_SYMBOL(__idmap_text_end) = .; \
- . = ALIGN(1 << LOG2_ROUNDUP(__hyp_idmap_size)); \
+ . = ALIGN(PAGE_SIZE); \
VMLINUX_SYMBOL(__hyp_idmap_text_start) = .; \
*(.hyp.idmap.text) \
VMLINUX_SYMBOL(__hyp_idmap_text_end) = .;
-/*
- * If the HYP idmap .text section is populated, it needs to be positioned
- * such that it will not cross a page boundary in the final output image.
- * So align it to the section size rounded up to the next power of 2.
- * If __hyp_idmap_size is undefined, the section will be empty so define
- * it as 0 in that case.
- */
-PROVIDE(__hyp_idmap_size = 0);
-
#ifdef CONFIG_HOTPLUG_CPU
#define ARM_CPU_DISCARD(x)
#define ARM_CPU_KEEP(x) x
diff --git a/arch/arm/kvm/init.S b/arch/arm/kvm/init.S
index 11fb1d56f449..3988e72d16ff 100644
--- a/arch/arm/kvm/init.S
+++ b/arch/arm/kvm/init.S
@@ -157,6 +157,3 @@ target: @ We're now in the trampoline code, switch page tables
__kvm_hyp_init_end:
.popsection
-
- .global __hyp_idmap_size
- .set __hyp_idmap_size, __kvm_hyp_init_end - __kvm_hyp_init
--
1.8.3.2
next prev parent reply other threads:[~2015-03-27 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 10:18 [PATCH] ARM, arm64: kvm: get rid of the bounce page Ard Biesheuvel
2015-03-27 10:18 ` Ard Biesheuvel [this message]
2015-03-27 11:09 ` [PATCH] ARM: kvm: round HYP section to page size instead of log2 upper bound Will Deacon
2015-03-27 11:12 ` Ard Biesheuvel
2015-03-27 12:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427451481-16053-2-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).