linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gregory.0xf0@gmail.com (Gregory Fong)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: debug: Add prompt for FRAME_POINTER to Kconfig.debug
Date: Wed,  8 Apr 2015 17:04:43 -0700	[thread overview]
Message-ID: <1428537883-19622-1-git-send-email-gregory.0xf0@gmail.com> (raw)

Without a prompt string, it is impossible to disable FRAME_POINTER on
ARM. It will simply set the default value anytime you run 'make'.

To reproduce the original issue, run:
  make multi_v7_defconfig
  scripts/config -d ARM_UNWIND
  make oldconfig
  # check .config, note that FRAME_POINTER=y
  scripts/config -d FRAME_POINTER
  make oldconfig
  # check .config, note that FRAME_POINTER is still y

Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 970de75..b881fd3 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -33,7 +33,7 @@ config STRICT_DEVMEM
 # traces, you can get a slightly smaller kernel by setting this option to
 # n, but then RMK will have to kill you ;).
 config FRAME_POINTER
-	bool
+	bool "Compile the kernel with frame pointers"
 	depends on !THUMB2_KERNEL
 	default y if !ARM_UNWIND || FUNCTION_GRAPH_TRACER
 	help
-- 
1.9.1

             reply	other threads:[~2015-04-09  0:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  0:04 Gregory Fong [this message]
2015-04-09  7:45 ` [RFC PATCH] ARM: debug: Add prompt for FRAME_POINTER to Kconfig.debug Russell King - ARM Linux
2015-04-09 18:16   ` Gregory Fong
2015-04-13 22:34 ` Gregory Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428537883-19622-1-git-send-email-gregory.0xf0@gmail.com \
    --to=gregory.0xf0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).