linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/9] mmc: sdhci-st: Update the quirks for this controller.
Date: Fri, 10 Apr 2015 09:58:28 +0100	[thread overview]
Message-ID: <1428656311-2605-7-git-send-email-peter.griffin@linaro.org> (raw)
In-Reply-To: <1428656311-2605-1-git-send-email-peter.griffin@linaro.org>

Some additional quirks need to be enabled now we support UHS
modes. This avoids some spurious warnings like

"Got data interrupt 0x00000002 even though no data operation was in progress"

Testing on stih410-b2120 board achieves the following speeds
with HS200 eMMC card.

max-frequency = 200Mhz
/dev/mmcblk0p1:
 Timing buffered disk reads: 270 MB in  3.02 seconds =  89.54 MB/sec

max-frequency = 100Mhz
root at debian-armhf:~# hdparm -t /dev/mmcblk0p1
/dev/mmcblk0p1:
 Timing buffered disk reads: 210 MB in  3.00 seconds =  70.00 MB/sec

max-frequency = 50Mhz
root at debian-armhf:~# hdparm -t /dev/mmcblk0p1
/dev/mmcblk0p1:
 Timing buffered disk reads: 118 MB in  3.00 seconds =  39.28 MB/sec

This is better than the 3.10 kernel which achieves 77.59 MB/sec
at 200Mhz clock (same board/soc/eMMC).

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
---
 drivers/mmc/host/sdhci-st.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 2ce842b..751452b 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -340,7 +340,10 @@ static const struct sdhci_ops sdhci_st_ops = {
 static const struct sdhci_pltfm_data sdhci_st_pdata = {
 	.ops = &sdhci_st_ops,
 	.quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC |
-	    SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
+		SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN |
+		SDHCI_QUIRK_NO_HISPD_BIT,
+	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN |
+		SDHCI_QUIRK2_STOP_WITH_TC,
 };
 
 
-- 
1.9.1

  parent reply	other threads:[~2015-04-10  8:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  8:58 [PATCH v4 0/9] Add sd/emmc support for stih407 family silicon Peter Griffin
2015-04-10  8:58 ` [PATCH v4 1/9] mmc: sdhci-st: Add macros for register offsets and bitfields for mmcss glue regs Peter Griffin
2015-04-10  8:58 ` [PATCH v4 2/9] mmc: sdhci-st: Add support for de-asserting reset signal and top regs resource Peter Griffin
2015-04-10  8:58 ` [PATCH v4 3/9] mmc: sdhci-st: Add delay management functions for top registers (eMMC) Peter Griffin
2015-04-10  8:58 ` [PATCH v4 4/9] mmc: sdhci-st: Add st_mmcss_cconfig function to configure mmcss glue registers Peter Griffin
2015-04-10  8:58 ` [PATCH v4 5/9] mmc: sdhci-st: Add sdhci_st_set_uhs_signaling function Peter Griffin
2015-04-10  8:58 ` Peter Griffin [this message]
2015-04-10  8:58 ` [PATCH v4 7/9] mmc: sdhci-st: Update ST SDHCI binding documentation Peter Griffin
2015-04-10  8:58 ` [PATCH v4 8/9] ARM: STi: DT: STiH407: Add dt nodes for sdhci and emmc Peter Griffin
2015-04-10  8:58 ` [PATCH v4 9/9] ARM: STi: DT: STiH418: " Peter Griffin
2015-04-10  9:15 ` [PATCH v4 0/9] Add sd/emmc support for stih407 family silicon Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428656311-2605-7-git-send-email-peter.griffin@linaro.org \
    --to=peter.griffin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).