linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v6 09/16] VFIO: add vfio_external_{mask|is_active|set_automasked}
Date: Mon, 13 Apr 2015 14:29:24 +0200	[thread overview]
Message-ID: <1428928171-18884-10-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1428928171-18884-1-git-send-email-eric.auger@linaro.org>

Introduces 3 new external functions aimed at doing actions
on VFIO devices:
- mask VFIO IRQ
- get the active status of VFIO IRQ (active at interrupt
  controller level or masked by the level-sensitive automasking).
- change the automasked property and switch the IRQ handler
  (between automasked/ non automasked)

Their implementation is based on bus specific callbacks.

Note there is no way to discriminate between user-space
masking and automasked handler masking. As a consequence, is_active
will return true in case the IRQ was masked by the user-space.

Signed-off-by: Eric Auger <eric.auger@linaro.org>

---

v5 -> v6:
- implementation now uses external ops
- prototype changed (index, start, count) and returns int

V4: creation
---
 drivers/vfio/vfio.c  | 39 +++++++++++++++++++++++++++++++++++++++
 include/linux/vfio.h | 16 ++++++++++++++++
 2 files changed, 55 insertions(+)

diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 33ae8c5..a36188e 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -1526,6 +1526,45 @@ long vfio_external_check_extension(struct vfio_group *group, unsigned long arg)
 }
 EXPORT_SYMBOL_GPL(vfio_external_check_extension);
 
+int vfio_external_mask(struct vfio_device *vdev, unsigned index,
+			unsigned start, unsigned count)
+{
+	if (vdev->ops->external_ops &&
+		vdev->ops->external_ops->mask)
+		return vdev->ops->external_ops->mask(vdev->device_data,
+						     index, start, count);
+	else
+		return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_mask);
+
+int vfio_external_is_active(struct vfio_device *vdev, unsigned index,
+			     unsigned start, unsigned count)
+{
+	if (vdev->ops->external_ops &&
+		vdev->ops->external_ops->is_active)
+		return vdev->ops->external_ops->is_active(vdev->device_data,
+							  index, start, count);
+	else
+		return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_is_active);
+
+int vfio_external_set_automasked(struct vfio_device *vdev,
+				  unsigned index, unsigned start,
+				  unsigned count, bool automasked)
+{
+	if (vdev->ops->external_ops &&
+		vdev->ops->external_ops->set_automasked)
+		return vdev->ops->external_ops->set_automasked(
+							vdev->device_data,
+							index, start,
+							count, automasked);
+	else
+		return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_set_automasked);
+
 /**
  * Module/class support
  */
diff --git a/include/linux/vfio.h b/include/linux/vfio.h
index b0ec474..a740392 100644
--- a/include/linux/vfio.h
+++ b/include/linux/vfio.h
@@ -123,6 +123,22 @@ extern struct vfio_device *vfio_device_get_external_user(struct file *filep);
 extern void vfio_device_put_external_user(struct vfio_device *vdev);
 extern struct device *vfio_external_base_device(struct vfio_device *vdev);
 
+extern int vfio_external_mask(struct vfio_device *vdev, unsigned index,
+			       unsigned start, unsigned count);
+/*
+ * returns whether the VFIO IRQ is active:
+ * true if not yet deactivated at interrupt controller level or if
+ * automasked (level sensitive IRQ). Unfortunately there is no way to
+ * discriminate between handler auto-masking and user-space masking
+ */
+extern int vfio_external_is_active(struct vfio_device *vdev,
+				    unsigned index, unsigned start,
+				    unsigned count);
+
+extern int vfio_external_set_automasked(struct vfio_device *vdev,
+					 unsigned index, unsigned start,
+					 unsigned count, bool automasked);
+
 struct pci_dev;
 #ifdef CONFIG_EEH
 extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev);
-- 
1.9.1

  parent reply	other threads:[~2015-04-13 12:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 12:29 [RFC v6 00/16] KVM-VFIO IRQ forward control Eric Auger
2015-04-13 12:29 ` [RFC v6 01/16] KVM: arm/arm64: Enable the KVM-VFIO device Eric Auger
2015-04-13 12:29 ` [RFC v6 02/16] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-04-13 12:29 ` [RFC v6 03/16] VFIO: platform: single handler using function pointer Eric Auger
2015-04-13 12:29 ` [RFC v6 04/16] KVM: kvm-vfio: User API for IRQ forwarding Eric Auger
2015-04-13 12:29 ` [RFC v6 05/16] VFIO: external user API for interaction with vfio devices Eric Auger
2015-04-13 12:29 ` [RFC v6 06/16] VFIO: Introduce vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` [RFC v6 07/16] VFIO: pci: initialize vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` [RFC v6 08/16] VFIO: platform: implement vfio_device_external_ops callbacks Eric Auger
2015-04-13 12:29 ` Eric Auger [this message]
2015-04-13 12:29 ` [RFC v6 10/16] KVM: kvm-vfio: wrappers to VFIO external API device helpers Eric Auger
2015-04-13 12:29 ` [RFC v6 11/16] KVM: kvm-vfio: wrappers for vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-04-13 12:29 ` [RFC v6 12/16] KVM: arm: rename pause into power_off Eric Auger
2015-04-13 12:29 ` [RFC v6 13/16] kvm: introduce kvm_arch_halt_guest and kvm_arch_resume_guest Eric Auger
2015-04-13 12:29 ` [RFC v6 14/16] kvm: arm/arm64: implement " Eric Auger
2015-04-13 12:29 ` [RFC v6 15/16] KVM: kvm-vfio: generic forwarding control Eric Auger
2015-04-13 12:29 ` [RFC v6 16/16] KVM: arm/arm64: vgic: " Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428928171-18884-10-git-send-email-eric.auger@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).