From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v6 10/16] KVM: kvm-vfio: wrappers to VFIO external API device helpers
Date: Mon, 13 Apr 2015 14:29:25 +0200 [thread overview]
Message-ID: <1428928171-18884-11-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1428928171-18884-1-git-send-email-eric.auger@linaro.org>
Provide wrapper functions that allow KVM-VFIO device code to
interact with a vfio device:
- kvm_vfio_device_get_external_user gets a handle to a struct
vfio_device from the vfio device file descriptor and increments
its reference counter,
- kvm_vfio_device_put_external_user decrements the reference counter
to a vfio device,
- kvm_vfio_external_base_device returns a handle to the struct device
of the vfio device.
Also kvm_vfio_get_vfio_device and kvm_vfio_put_vfio_device helpers
are introduced.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v3 -> v4:
- wrappers are no more exposed in kvm_host and become kvm/vfio.c static
functions
- added kvm_vfio_get_vfio_device/kvm_vfio_put_vfio_device in that
patch file
v2 -> v3:
- reword the commit message and title
v1 -> v2:
- kvm_vfio_external_get_base_device renamed into
kvm_vfio_external_base_device
- kvm_vfio_external_get_type removed
---
virt/kvm/vfio.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 74 insertions(+)
diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c
index 620e37f..80a45e4 100644
--- a/virt/kvm/vfio.c
+++ b/virt/kvm/vfio.c
@@ -60,6 +60,80 @@ static void kvm_vfio_group_put_external_user(struct vfio_group *vfio_group)
symbol_put(vfio_group_put_external_user);
}
+static struct vfio_device *kvm_vfio_device_get_external_user(struct file *filep)
+{
+ struct vfio_device *vdev;
+ struct vfio_device *(*fn)(struct file *);
+
+ fn = symbol_get(vfio_device_get_external_user);
+ if (!fn)
+ return ERR_PTR(-EINVAL);
+
+ vdev = fn(filep);
+
+ symbol_put(vfio_device_get_external_user);
+
+ return vdev;
+}
+
+static void kvm_vfio_device_put_external_user(struct vfio_device *vdev)
+{
+ void (*fn)(struct vfio_device *);
+
+ fn = symbol_get(vfio_device_put_external_user);
+ if (!fn)
+ return;
+
+ fn(vdev);
+
+ symbol_put(vfio_device_put_external_user);
+}
+
+static struct device *kvm_vfio_external_base_device(struct vfio_device *vdev)
+{
+ struct device *(*fn)(struct vfio_device *);
+ struct device *dev;
+
+ fn = symbol_get(vfio_external_base_device);
+ if (!fn)
+ return NULL;
+
+ dev = fn(vdev);
+
+ symbol_put(vfio_external_base_device);
+
+ return dev;
+}
+
+/**
+ * kvm_vfio_get_vfio_device - Returns a handle to a vfio-device
+ *
+ * Checks it is a valid vfio device and increments its reference counter
+ * @fd: file descriptor of the vfio platform device
+ */
+static struct vfio_device *kvm_vfio_get_vfio_device(int fd)
+{
+ struct fd f = fdget(fd);
+ struct vfio_device *vdev;
+
+ if (!f.file)
+ return ERR_PTR(-EINVAL);
+ vdev = kvm_vfio_device_get_external_user(f.file);
+ fdput(f);
+ return vdev;
+}
+
+/**
+ * kvm_vfio_put_vfio_device: decrements the reference counter of the
+ * vfio platform * device
+ *
+ * @vdev: vfio_device handle to release
+ */
+static void kvm_vfio_put_vfio_device(struct vfio_device *vdev)
+{
+ kvm_vfio_device_put_external_user(vdev);
+}
+
static bool kvm_vfio_group_is_coherent(struct vfio_group *vfio_group)
{
long (*fn)(struct vfio_group *, unsigned long);
--
1.9.1
next prev parent reply other threads:[~2015-04-13 12:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 12:29 [RFC v6 00/16] KVM-VFIO IRQ forward control Eric Auger
2015-04-13 12:29 ` [RFC v6 01/16] KVM: arm/arm64: Enable the KVM-VFIO device Eric Auger
2015-04-13 12:29 ` [RFC v6 02/16] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-04-13 12:29 ` [RFC v6 03/16] VFIO: platform: single handler using function pointer Eric Auger
2015-04-13 12:29 ` [RFC v6 04/16] KVM: kvm-vfio: User API for IRQ forwarding Eric Auger
2015-04-13 12:29 ` [RFC v6 05/16] VFIO: external user API for interaction with vfio devices Eric Auger
2015-04-13 12:29 ` [RFC v6 06/16] VFIO: Introduce vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` [RFC v6 07/16] VFIO: pci: initialize vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` [RFC v6 08/16] VFIO: platform: implement vfio_device_external_ops callbacks Eric Auger
2015-04-13 12:29 ` [RFC v6 09/16] VFIO: add vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-04-13 12:29 ` Eric Auger [this message]
2015-04-13 12:29 ` [RFC v6 11/16] KVM: kvm-vfio: wrappers for vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-04-13 12:29 ` [RFC v6 12/16] KVM: arm: rename pause into power_off Eric Auger
2015-04-13 12:29 ` [RFC v6 13/16] kvm: introduce kvm_arch_halt_guest and kvm_arch_resume_guest Eric Auger
2015-04-13 12:29 ` [RFC v6 14/16] kvm: arm/arm64: implement " Eric Auger
2015-04-13 12:29 ` [RFC v6 15/16] KVM: kvm-vfio: generic forwarding control Eric Auger
2015-04-13 12:29 ` [RFC v6 16/16] KVM: arm/arm64: vgic: " Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428928171-18884-11-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).