From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v6 08/16] VFIO: platform: implement vfio_device_external_ops callbacks
Date: Mon, 13 Apr 2015 14:29:23 +0200 [thread overview]
Message-ID: <1428928171-18884-9-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1428928171-18884-1-git-send-email-eric.auger@linaro.org>
This patch adds the implementation for the 3 external callbacks of
vfio_device_external_ops struct, namely active, is_active,
set_automasked. Also vfio_device_ops and vfio_device_external_ops are
set accordingly.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v6: creation
---
drivers/vfio/platform/vfio_platform_common.c | 7 ++++
drivers/vfio/platform/vfio_platform_irq.c | 49 +++++++++++++++++++++++++++
drivers/vfio/platform/vfio_platform_private.h | 11 ++++++
3 files changed, 67 insertions(+)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index abcff7a..4113d46 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -471,6 +471,12 @@ static int vfio_platform_mmap(void *device_data, struct vm_area_struct *vma)
return -EINVAL;
}
+static struct vfio_device_external_ops vfio_platform_external_ops = {
+ .mask = vfio_platform_external_mask,
+ .is_active = vfio_platform_external_is_active,
+ .set_automasked = vfio_platform_external_set_automasked,
+};
+
static const struct vfio_device_ops vfio_platform_ops = {
.name = "vfio-platform",
.open = vfio_platform_open,
@@ -479,6 +485,7 @@ static const struct vfio_device_ops vfio_platform_ops = {
.read = vfio_platform_read,
.write = vfio_platform_write,
.mmap = vfio_platform_mmap,
+ .external_ops = &vfio_platform_external_ops
};
int vfio_platform_probe_common(struct vfio_platform_device *vdev,
diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
index 8eb65c1..f6d83ed 100644
--- a/drivers/vfio/platform/vfio_platform_irq.c
+++ b/drivers/vfio/platform/vfio_platform_irq.c
@@ -231,6 +231,55 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
return 0;
}
+int vfio_platform_external_mask(void *device_data, unsigned index,
+ unsigned start, unsigned count)
+{
+ struct vfio_platform_device *vdev = device_data;
+
+ vfio_platform_mask(&vdev->irqs[index]);
+ return 0;
+}
+
+int vfio_platform_external_is_active(void *device_data, unsigned index,
+ unsigned start, unsigned count)
+{
+ unsigned long flags;
+ struct vfio_platform_device *vdev = device_data;
+ struct vfio_platform_irq *irq = &vdev->irqs[index];
+ bool active, masked, outstanding;
+ int ret;
+
+ spin_lock_irqsave(&irq->lock, flags);
+
+ ret = irq_get_irqchip_state(irq->hwirq, IRQCHIP_STATE_ACTIVE, &active);
+ BUG_ON(ret);
+ masked = irq->masked;
+ outstanding = active || masked;
+
+ spin_unlock_irqrestore(&irq->lock, flags);
+ return outstanding;
+}
+
+int vfio_platform_external_set_automasked(void *device_data, unsigned index,
+ unsigned start, unsigned count,
+ bool automasked)
+{
+ unsigned long flags;
+ struct vfio_platform_device *vdev = device_data;
+ struct vfio_platform_irq *irq = &vdev->irqs[index];
+
+ spin_lock_irqsave(&irq->lock, flags);
+ if (automasked) {
+ irq->flags |= VFIO_IRQ_INFO_AUTOMASKED;
+ irq->handler = vfio_automasked_irq_handler;
+ } else {
+ irq->flags &= ~VFIO_IRQ_INFO_AUTOMASKED;
+ irq->handler = vfio_irq_handler;
+ }
+ spin_unlock_irqrestore(&irq->lock, flags);
+ return 0;
+}
+
static int vfio_platform_set_irq_trigger(struct vfio_platform_device *vdev,
unsigned index, unsigned start,
unsigned count, uint32_t flags,
diff --git a/drivers/vfio/platform/vfio_platform_private.h b/drivers/vfio/platform/vfio_platform_private.h
index eb91deb..253caa3 100644
--- a/drivers/vfio/platform/vfio_platform_private.h
+++ b/drivers/vfio/platform/vfio_platform_private.h
@@ -83,4 +83,15 @@ extern int vfio_platform_set_irqs_ioctl(struct vfio_platform_device *vdev,
unsigned start, unsigned count,
void *data);
+extern int vfio_platform_external_mask(void *device_data, unsigned index,
+ unsigned start, unsigned count);
+extern int vfio_platform_external_is_active(void *device_data,
+ unsigned index, unsigned start,
+ unsigned count);
+extern int vfio_platform_external_set_automasked(void *device_data,
+ unsigned index,
+ unsigned start,
+ unsigned count,
+ bool automasked);
+
#endif /* VFIO_PLATFORM_PRIVATE_H */
--
1.9.1
next prev parent reply other threads:[~2015-04-13 12:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 12:29 [RFC v6 00/16] KVM-VFIO IRQ forward control Eric Auger
2015-04-13 12:29 ` [RFC v6 01/16] KVM: arm/arm64: Enable the KVM-VFIO device Eric Auger
2015-04-13 12:29 ` [RFC v6 02/16] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-04-13 12:29 ` [RFC v6 03/16] VFIO: platform: single handler using function pointer Eric Auger
2015-04-13 12:29 ` [RFC v6 04/16] KVM: kvm-vfio: User API for IRQ forwarding Eric Auger
2015-04-13 12:29 ` [RFC v6 05/16] VFIO: external user API for interaction with vfio devices Eric Auger
2015-04-13 12:29 ` [RFC v6 06/16] VFIO: Introduce vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` [RFC v6 07/16] VFIO: pci: initialize vfio_device_external_ops Eric Auger
2015-04-13 12:29 ` Eric Auger [this message]
2015-04-13 12:29 ` [RFC v6 09/16] VFIO: add vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-04-13 12:29 ` [RFC v6 10/16] KVM: kvm-vfio: wrappers to VFIO external API device helpers Eric Auger
2015-04-13 12:29 ` [RFC v6 11/16] KVM: kvm-vfio: wrappers for vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-04-13 12:29 ` [RFC v6 12/16] KVM: arm: rename pause into power_off Eric Auger
2015-04-13 12:29 ` [RFC v6 13/16] kvm: introduce kvm_arch_halt_guest and kvm_arch_resume_guest Eric Auger
2015-04-13 12:29 ` [RFC v6 14/16] kvm: arm/arm64: implement " Eric Auger
2015-04-13 12:29 ` [RFC v6 15/16] KVM: kvm-vfio: generic forwarding control Eric Auger
2015-04-13 12:29 ` [RFC v6 16/16] KVM: arm/arm64: vgic: " Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428928171-18884-9-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).