* [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO
@ 2015-04-14 14:05 Fabio Estevam
2015-04-14 17:51 ` Stefan Wahren
2015-04-27 11:46 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2015-04-14 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On imx23-olinuxino the LED turns on when level logic high is aplied to
GPIO2_1.
Fix the gpios property accordingly.
Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx23-olinuxino.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 7e6eef2..839a3b9 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -12,6 +12,7 @@
*/
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "imx23.dtsi"
/ {
@@ -122,7 +123,7 @@
user {
label = "green";
- gpios = <&gpio2 1 1>;
+ gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
};
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO
2015-04-14 14:05 [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO Fabio Estevam
@ 2015-04-14 17:51 ` Stefan Wahren
2015-04-14 17:57 ` Fabio Estevam
2015-04-27 11:46 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2015-04-14 17:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio,
> Fabio Estevam <fabio.estevam@freescale.com> hat am 14. April 2015 um 16:05
> geschrieben:
>
>
> On imx23-olinuxino the LED turns on when level logic high is aplied to
> GPIO2_1.
>
> Fix the gpios property accordingly.
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment?
Thanks
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO
2015-04-14 17:51 ` Stefan Wahren
@ 2015-04-14 17:57 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2015-04-14 17:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stefan,
On Tue, Apr 14, 2015 at 2:51 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
>
> I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment?
Thanks for testing.
Unfortunately, I don't have access to my mx23 olinuxino board and
could not test it.
I have looked in all schematics (maxi, micro, mini and nano) and all
of them require logic level high to turn on the LED.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO
2015-04-14 14:05 [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO Fabio Estevam
2015-04-14 17:51 ` Stefan Wahren
@ 2015-04-27 11:46 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2015-04-27 11:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 14, 2015 at 11:05:04AM -0300, Fabio Estevam wrote:
> On imx23-olinuxino the LED turns on when level logic high is aplied to
> GPIO2_1.
>
> Fix the gpios property accordingly.
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-27 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-14 14:05 [PATCH] ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO Fabio Estevam
2015-04-14 17:51 ` Stefan Wahren
2015-04-14 17:57 ` Fabio Estevam
2015-04-27 11:46 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).