From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors
Date: Mon, 20 Apr 2015 14:41:04 +0100 [thread overview]
Message-ID: <1429537265-22367-1-git-send-email-peter.griffin@linaro.org> (raw)
Hi Tejun / Brian,
I tested the initial version of this patch (see http://patchwork.ozlabs.org/patch/459422/)
on stih410 hardware, however it introduced a NULL ptr dereference, as plat_data
isn't set until ahci_platform_init_host() but plat_data was being used before
this in the st_ahci_probe_resets and st_ahci_deassert_resets() functions.
Also the original patch had a conflict with a patch which Tejun has already
taken of mine
(see here http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/326900.html).
So this V2 fixes the conflict, and re-works st_ahci_probe_resets and
st_ahci_deassert_resets functions to take struct ahci_host_priv *hpriv as
a parameter.
Brian - I'm not sure of the correct patch etiquette here. Currently I have
taken authorship of the patch and added a "Suggested-by" tag on the V2.
Maybe I should have also kept your "Signed-off-by" or done something else?
Please let me know if this is OK or if you would like something changed.
regards,
Peter.
Changes since v1:
- Rework st_ahci_deassert_resets and st_ahci_probe_resets
- Fix conflict with "st_configure_oob must be called after IP is clocked." patch
Peter Griffin (1):
ata: ahci_st: fixup layering violations / drvdata errors
drivers/ata/ahci_st.c | 49 ++++++++++++++++++++++++-------------------------
1 file changed, 24 insertions(+), 25 deletions(-)
--
1.9.1
next reply other threads:[~2015-04-20 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 13:41 Peter Griffin [this message]
2015-04-20 13:41 ` [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors Peter Griffin
2015-04-29 14:30 ` Maxime Coquelin
2015-04-23 1:18 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429537265-22367-1-git-send-email-peter.griffin@linaro.org \
--to=peter.griffin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).