linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: timo.kokkonen@offcode.fi (Timo Kokkonen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail
Date: Wed, 22 Apr 2015 14:11:41 +0300	[thread overview]
Message-ID: <1429701102-22320-8-git-send-email-timo.kokkonen@offcode.fi> (raw)
In-Reply-To: <1429701102-22320-1-git-send-email-timo.kokkonen@offcode.fi>

Structures allocated on the beginning of the probe function must be
freed in case of failure.

Signed-off-by: Timo Kokkonen <timo.kokkonen@offcode.fi>
---
 drivers/watchdog/omap_wdt.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index 1e6be9e..bbaf39a 100644
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -226,8 +226,10 @@ static int omap_wdt_probe(struct platform_device *pdev)
 	/* reserve static register mappings */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	wdev->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(wdev->base))
-		return PTR_ERR(wdev->base);
+	if (IS_ERR(wdev->base)) {
+		ret = PTR_ERR(wdev->base);
+		goto err_ioremap;
+	}
 
 	omap_wdt->info	      = &omap_wdt_info;
 	omap_wdt->ops	      = &omap_wdt_ops;
@@ -258,10 +260,8 @@ static int omap_wdt_probe(struct platform_device *pdev)
 	omap_wdt_disable(wdev);
 
 	ret = watchdog_register_device(omap_wdt);
-	if (ret) {
-		pm_runtime_disable(wdev->dev);
-		return ret;
-	}
+	if (ret)
+		goto err_register_device;
 
 	pr_info("OMAP Watchdog Timer Rev 0x%02x: initial timeout %d sec\n",
 		readl_relaxed(wdev->base + OMAP_WATCHDOG_REV) & 0xFF,
@@ -270,6 +270,14 @@ static int omap_wdt_probe(struct platform_device *pdev)
 	pm_runtime_put_sync(wdev->dev);
 
 	return 0;
+
+err_register_device:
+	pm_runtime_disable(wdev->dev);
+err_ioremap:
+	kfree(wdev);
+	kfree(omap_wdt);
+
+	return ret;
 }
 
 static void omap_wdt_shutdown(struct platform_device *pdev)
-- 
2.1.0

  parent reply	other threads:[~2015-04-22 11:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 11:11 [PATCHv7 0/8] watchdog: Extend kernel API and add early_timeout_sec feature Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 1/8] watchdog: Extend kernel API to know about HW limitations Timo Kokkonen
2015-04-24 17:08   ` Guenter Roeck
2015-04-27  5:41     ` Timo Kokkonen
2015-05-04  7:58   ` Uwe Kleine-König
2015-05-04  9:40     ` Timo Kokkonen
2015-05-04 15:43   ` Guenter Roeck
2015-05-05  6:26     ` Timo Kokkonen
2015-05-04 21:17   ` Marc Kleine-Budde
2015-04-22 11:11 ` [PATCHv7 2/8] watchdog: Allow watchdog to reset device at early boot Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 3/8] devicetree: Document generic watchdog properties Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 4/8] Documentation/watchdog: watchdog-test.c: Add support for changing timeout Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 5/8] watchdog: at91sam9_wdt: Convert to use new watchdog core extensions Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 6/8] watchdog: imx2_wdt: Convert to use new " Timo Kokkonen
2015-05-05  8:11   ` Marc Kleine-Budde
2015-05-05  8:31     ` Marc Kleine-Budde
2015-05-05  9:07       ` Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen [this message]
2015-04-26 15:32   ` [PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail Guenter Roeck
2015-04-27  5:50     ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 8/8] watchdog: omap_wdt: Convert to use new core extensions Timo Kokkonen
2015-05-03 18:56   ` Uwe Kleine-König
2015-05-04  5:59     ` Timo Kokkonen
2015-05-04  7:04       ` Uwe Kleine-König
2015-05-04 10:06         ` Timo Kokkonen
2015-05-07  6:42         ` Timo Kokkonen
2015-05-07  7:30           ` Uwe Kleine-König
2015-05-07  7:39             ` Timo Kokkonen
2015-05-04 16:08       ` Guenter Roeck
2015-05-05 13:50 ` [PATCHv7 0/8] watchdog: Extend kernel API and add early_timeout_sec feature Uwe Kleine-König
2015-05-06  7:26   ` Timo Kokkonen
2015-05-06  7:48     ` Uwe Kleine-König
2015-05-06  8:23       ` Timo Kokkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429701102-22320-8-git-send-email-timo.kokkonen@offcode.fi \
    --to=timo.kokkonen@offcode.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).