From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm64: perf: Fix the pmu node name in warning message
Date: Thu, 23 Apr 2015 14:50:33 +0100 [thread overview]
Message-ID: <1429797033-3787-4-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1429797033-3787-1-git-send-email-will.deacon@arm.com>
From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
With commit d5efd9cc9cf2 ("arm64: pmu: add support for interrupt-affinity
property"), we print a warning when we find a PMU SPI with a missing
missing interrupt-affinity property in a pmu node. Unfortunately, we
pass the wrong (NULL) device node to of_node_full_name, resulting in
unhelpful messages such as:
hw perfevents: Failed to parse <no-node>/interrupt-affinity[0]
This patch fixes the name to that of the pmu node.
Fixes: d5efd9cc9cf2 (arm64: pmu: add support for interrupt-affinity property)
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm64/kernel/perf_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 2a9cbcb61126..23f25acf43a9 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -1332,7 +1332,7 @@ static int armpmu_device_probe(struct platform_device *pdev)
i);
if (!dn) {
pr_warn("Failed to parse %s/interrupt-affinity[%d]\n",
- of_node_full_name(dn), i);
+ of_node_full_name(pdev->dev.of_node), i);
break;
}
--
2.1.4
next prev parent reply other threads:[~2015-04-23 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 13:50 [PATCH 1/4] ARM: perf: don't warn about missing interrupt-affinity property for PPIs Will Deacon
2015-04-23 13:50 ` [PATCH 2/4] ARM perf: Fix the pmu node name in warning message Will Deacon
2015-04-23 13:58 ` Mark Rutland
2015-05-01 13:59 ` Sudeep Holla
2015-05-01 14:07 ` Will Deacon
2015-05-01 14:07 ` Mark Rutland
2015-05-01 14:20 ` Sudeep Holla
2015-04-23 13:50 ` [PATCH 3/4] arm64: perf: don't warn about missing interrupt-affinity property for PPIs Will Deacon
2015-04-23 13:50 ` Will Deacon [this message]
2015-04-23 14:01 ` [PATCH 1/4] ARM: " Mark Rutland
2015-04-23 14:02 ` Will Deacon
2015-04-23 14:11 ` Mark Rutland
2015-04-23 15:56 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429797033-3787-4-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).