[PATCH 2/2] arm64: dts: qcom: Add msm8916 CoreSight components

[ivan.ivanov@linaro.org (Ivan T. Ivanov)]

On Wed, 2015-04-29 at 10:49 -0600, Mathieu Poirier wrote:
> On 29 April 2015 at 06:20, Ivan T. Ivanov ivanov at linaro.org> wrote:


> > +
> > +???????funnel at 821000 {
> > +               compatible = "arm,coresight-funnel", "arm,primecell";
> > +               reg = <0x821000 0x1000>;
> > +
> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> > +               clock-names = "apb_pclk", "atclk";
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +???????????????????????port at 4 {
> > +                               reg = <4>;
> > +                               funnel0_in4: endpoint {
> > +                                       slave-mode;
> > +                                       remote-endpoint = <&funnel1_out>;
> > +                               };
> > +                       };
> > +???????????????????????port at 8 {
> > +                               reg = <0>;
> > +                               funnel0_out: endpoint {
> > +                                       remote-endpoint = <&etf_in>;
> > +                               };
> > +                       };
> 
> Please add a comment indicating what the other ports are connected to.
> 
> > +               };
> > +       };
> > +
> > +???????replicator at 824000 {
> > +               compatible = "qcom,coresight-replicator", "arm,primecell";
> > +               reg = <0x824000 0x1000>;
> > +
> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> > +               clock-names = "apb_pclk", "atclk";
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +???????????????????????port at 0 {
> > +                               reg = <0>;
> > +                               replicator_out0: endpoint {
> > +                                       remote-endpoint = <&etr_in>;
> > +                               };
> > +                       };
> > +???????????????????????port at 1 {
> > +                               reg = <1>;
> > +                               replicator_out1: endpoint {
> > +                                       remote-endpoint = <&tpiu_in>;
> > +                               };
> > +                       };
> > +???????????????????????port at 2 {
> > +                               reg = <0>;
> > +                               replicator_in: endpoint {
> > +                                       slave-mode;
> > +                                       remote-endpoint = <&etf_out>;
> > +                               };
> > +                       };
> 
> Same comment as with the funnel component.

Sorry, but what do you mean here?

Regards,
Ivan