From: shenwei.wang@freescale.com (Shenwei Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/18] ARM: imx: Reimplemented the _mxc_timer_init based on IP version
Date: Thu, 30 Apr 2015 09:44:23 -0500 [thread overview]
Message-ID: <1430405073-13106-9-git-send-email-shenwei.wang@freescale.com> (raw)
In-Reply-To: <1430405073-13106-1-git-send-email-shenwei.wang@freescale.com>
Reimplemented the function of _mxc_timer_init just based on the
version of timer IP block.
Signed-off-by: Shenwei Wang <shenwei.wang@freescale.com>
---
arch/arm/mach-imx/time.c | 75 +++++++++++++++++++++---------------------------
1 file changed, 33 insertions(+), 42 deletions(-)
diff --git a/arch/arm/mach-imx/time.c b/arch/arm/mach-imx/time.c
index 451f761..cf07401 100644
--- a/arch/arm/mach-imx/time.c
+++ b/arch/arm/mach-imx/time.c
@@ -486,53 +486,44 @@ static void __init _mxc_timer_init_v3(int irq, struct clk *clk_per,
setup_irq(irq, &tm->act);
}
-static void __init _mxc_timer_init(int irq,
- struct clk *clk_per, struct clk *clk_ipg)
+static void __init _mxc_timer_init(int irq, struct clk *clk_per,
+ struct clk *clk_ipg, struct imx_timer *tm)
{
- uint32_t tctl_val;
-
- if (IS_ERR(clk_per)) {
- pr_err("i.MX timer: unable to get clk\n");
- return;
- }
- if (!IS_ERR(clk_ipg))
- clk_prepare_enable(clk_ipg);
-
- clk_prepare_enable(clk_per);
+ switch (tm->version) {
+ case IMX_TIMER_V0:
+ tm->gpt_irq_enable = gpt_irq_enable_v0_v1;
+ tm->gpt_irq_disable = gpt_irq_disable_v0_v1;
+ tm->gpt_irq_acknowledge = gpt_irq_acknowledge_v0;
+ _mxc_timer_init_v0_v1(irq, clk_per, clk_ipg, tm);
+ break;
- /*
- * Initialise to a known state (all timers off, and timing reset)
- */
+ case IMX_TIMER_V1:
+ tm->gpt_irq_enable = gpt_irq_enable_v0_v1;
+ tm->gpt_irq_disable = gpt_irq_disable_v0_v1;
+ tm->gpt_irq_acknowledge = gpt_irq_acknowledge_v1;
+ _mxc_timer_init_v0_v1(irq, clk_per, clk_ipg, tm);
+ break;
- __raw_writel(0, timer_base + MXC_TCTL);
- __raw_writel(0, timer_base + MXC_TPRER); /* see datasheet note */
-
- if (timer_is_v2()) {
- tctl_val = V2_TCTL_FRR | V2_TCTL_WAITEN | MXC_TCTL_TEN;
- if (clk_get_rate(clk_per) == V2_TIMER_RATE_OSC_DIV8) {
- tctl_val |= V2_TCTL_CLK_OSC_DIV8;
- if (cpu_is_imx6dl() || cpu_is_imx6sx()) {
- /* 24 / 8 = 3 MHz */
- __raw_writel(7 << V2_TPRER_PRE24M,
- timer_base + MXC_TPRER);
- tctl_val |= V2_TCTL_24MEN;
- }
- } else {
- tctl_val |= V2_TCTL_CLK_PER;
- }
- } else {
- tctl_val = MX1_2_TCTL_FRR | MX1_2_TCTL_CLK_PCLK1 | MXC_TCTL_TEN;
- }
+ case IMX_TIMER_V2:
+ tm->gpt_irq_enable = gpt_irq_enable_v2_v3;
+ tm->gpt_irq_disable = gpt_irq_disable_v2_v3;
+ tm->gpt_irq_acknowledge = gpt_irq_acknowledge_v2_v3;
+ _mxc_timer_init_v2(irq, clk_per, clk_ipg, tm);
+ break;
- __raw_writel(tctl_val, timer_base + MXC_TCTL);
+ case IMX_TIMER_V3:
+ tm->gpt_irq_enable = gpt_irq_enable_v2_v3;
+ tm->gpt_irq_disable = gpt_irq_disable_v2_v3;
+ tm->gpt_irq_acknowledge = gpt_irq_acknowledge_v2_v3;
+ _mxc_timer_init_v3(irq, clk_per, clk_ipg, tm);
+ break;
- /* init and register the timer to the framework */
- mxc_clocksource_init(clk_per, 0);
- mxc_clockevent_init(clk_per, 0);
+ default:
+ pr_err("<%s> timer device node is not supported\r\n", __func__);
+ break;
- /* Make irqs happen */
- setup_irq(irq, &mxc_timer_irq);
+ }
}
void __init mxc_timer_init(unsigned long pbase, int irq, int ver)
@@ -560,7 +551,7 @@ void __init mxc_timer_init(unsigned long pbase, int irq, int ver)
timer->act.dev_id = timer;
timer->act.handler = mxc_timer_interrupt;
- _mxc_timer_init(irq, clk_per, clk_ipg);
+ _mxc_timer_init(irq, clk_per, clk_ipg, timer);
}
struct imx_timer_ip_combo {
@@ -633,7 +624,7 @@ static void __init mxc_timer_init_dt(struct device_node *np)
timer->act.dev_id = timer;
timer->act.handler = mxc_timer_interrupt;
- _mxc_timer_init(irq, clk_per, clk_ipg);
+ _mxc_timer_init(irq, clk_per, clk_ipg, timer);
}
CLOCKSOURCE_OF_DECLARE(mx1_timer, "fsl,imx1-gpt", mxc_timer_init_dt);
--
1.9.1
next prev parent reply other threads:[~2015-04-30 14:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:44 [PATCH 00/18] ARM: imx: make the imx timer driver implementation independent of SoCs Shenwei Wang
2015-04-30 14:44 ` [PATCH 01/18] ARM: imx: Add a parameter to mxc_timer_init Shenwei Wang
2015-05-14 8:02 ` Shawn Guo
2015-05-14 13:48 ` Shenwei Wang
2015-04-30 14:44 ` [PATCH 02/18] ARM: imx: Add the definitions for imx_timer and its versions Shenwei Wang
2015-05-15 1:18 ` Shawn Guo
2015-05-15 15:47 ` Shenwei Wang
2015-04-30 14:44 ` [PATCH 03/18] ARM: imx: Add an array of timer IP block versions Shenwei Wang
2015-05-15 1:33 ` Shawn Guo
2015-04-30 14:44 ` [PATCH 04/18] ARM: imx: Added one more parameter for mxc_clockevent_init Shenwei Wang
2015-04-30 14:44 ` [PATCH 05/18] ARM: imx: Added one more parameter for mxc_clocksource_init Shenwei Wang
2015-04-30 14:44 ` [PATCH 06/18] ARM: imx: New timer driver APIs based on IP block Shenwei Wang
2015-05-15 1:44 ` Shawn Guo
2015-04-30 14:44 ` [PATCH 07/18] ARM: imx: Initialize the imx_timer structure Shenwei Wang
2015-05-15 2:05 ` Shawn Guo
2015-04-30 14:44 ` Shenwei Wang [this message]
2015-04-30 14:44 ` [PATCH 09/18] ARM: imx: Removed the SoC relating codes in mxc_timer_interrupt Shenwei Wang
2015-04-30 14:44 ` [PATCH 10/18] ARM: imx: Removed the SoC relating codes in mxc_set_mode Shenwei Wang
2015-04-30 14:44 ` [PATCH 11/18] ARM: imx: Enabled the unused parameter Shenwei Wang
2015-04-30 14:44 ` [PATCH 12/18] ARM: imx: Remove one global variable in mxc_clocksource_init Shenwei Wang
2015-04-30 14:44 ` [PATCH 13/18] ARM: imx: Removed the unused functions and variables Shenwei Wang
2015-04-30 14:44 ` [PATCH 14/18] ARM: imx: Removed the global variable "timer_base" Shenwei Wang
2015-04-30 14:44 ` [PATCH 15/18] ARM: imx: Remove the SoC relating codes in mxc_clockevent_init Shenwei Wang
2015-04-30 14:44 ` [PATCH 16/18] ARM: imx: Move the variable clockevent_mode into mxc_set_mode Shenwei Wang
2015-04-30 14:44 ` [PATCH 17/18] ARM: imx: Codes clean up Shenwei Wang
2015-04-30 14:44 ` [PATCH 18/18] ARM: imx: Move time.c into drivers/clocksources Shenwei Wang
2015-05-15 7:54 ` [PATCH 00/18] ARM: imx: make the imx timer driver implementation independent of SoCs Shawn Guo
2015-05-15 15:39 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430405073-13106-9-git-send-email-shenwei.wang@freescale.com \
--to=shenwei.wang@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).