From: tharvey@gateworks.com (Tim Harvey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx: thermal: use CPU temperature grade info for thresholds
Date: Thu, 30 Apr 2015 09:02:37 -0700 [thread overview]
Message-ID: <1430409757-16195-1-git-send-email-tharvey@gateworks.com> (raw)
The IMX6Q/IMX6DL SoC's have a 2-bit temperature grade stored in OTP. Instead
of assuming 85C for passive cooling threshold and 105C for critical use
the thermal grade for these configurations. For IMX6SX which does not have
a temperature grade in OTP (according to the ref manual) assume 105C critical.
We will default the user-settable passive threshold to crit - 20C.
Cc: Anson Huang <b20788@freescale.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/thermal/imx_thermal.c | 64 +++++++++++++++++++++++++++++++++----------
1 file changed, 49 insertions(+), 15 deletions(-)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 2ccbc07..c6a4eed 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -55,6 +55,7 @@
#define TEMPSENSE2_PANIC_VALUE_SHIFT 16
#define TEMPSENSE2_PANIC_VALUE_MASK 0xfff0000
+#define OCOTP_MEM0 0x0480
#define OCOTP_ANA1 0x04e0
/* The driver supports 1 passive trip point and 1 critical trip point */
@@ -64,12 +65,6 @@ enum imx_thermal_trip {
IMX_TRIP_NUM,
};
-/*
- * It defines the temperature in millicelsius for passive trip point
- * that will trigger cooling action when crossed.
- */
-#define IMX_TEMP_PASSIVE 85000
-
#define IMX_POLLING_DELAY 2000 /* millisecond */
#define IMX_PASSIVE_DELAY 1000
@@ -106,6 +101,7 @@ struct imx_thermal_data {
int irq;
struct clk *thermal_clk;
const struct thermal_soc_data *socdata;
+ const char *temp_grade;
};
static void imx_set_panic_temp(struct imx_thermal_data *data,
@@ -289,7 +285,8 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip,
if (trip == IMX_TRIP_CRITICAL)
return -EPERM;
- if (temp > IMX_TEMP_PASSIVE)
+ /* do not allow passive to be set higher than critical - 20C */
+ if (temp > (data->temp_critical - (1000 * 20)))
return -EINVAL;
data->temp_passive = temp;
@@ -404,17 +401,50 @@ static int imx_get_sensor_data(struct platform_device *pdev)
data->c1 = temp64;
data->c2 = n1 * data->c1 + 1000 * t1;
- /*
- * Set the default passive cooling trip point,
- * can be changed from userspace.
- */
- data->temp_passive = IMX_TEMP_PASSIVE;
+ /* Assume Extended Commercial temperature grade limits (105C max) */
+ data->temp_grade = "unknown";
+ data->temp_critical = 105000;
+
+ /* For IMX6Q use OTP for thermal grade */
+ if (data->socdata->version == TEMPMON_IMX6Q) {
+ ret = regmap_read(map, OCOTP_MEM0, &val);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to read temp grade: %d\n",
+ ret);
+ return ret;
+ }
+
+ if (val == 0 || val == ~0) {
+ dev_err(&pdev->dev, "invalid temp grade data\n");
+ return -EINVAL;
+ }
+
+ /* The maximum die temp is specified by the Temperature Grade */
+ switch ((val >> 6) & 0x3) {
+ case 0: /* Commercial (0 to 95C) */
+ data->temp_grade = "Commercial";
+ data->temp_critical = 95000;
+ break;
+ case 1: /* Extended Commercial (-20 to 105C) */
+ data->temp_grade = "Extended Commercial";
+ data->temp_critical = 105000;
+ break;
+ case 2: /* Industrial (-40 to 105C) */
+ data->temp_grade = "Industrial";
+ data->temp_critical = 105000;
+ break;
+ case 3: /* Automotive (-40 to 125C) */
+ data->temp_grade = "Automotive";
+ data->temp_critical = 125000;
+ break;
+ }
+ }
/*
- * The maximum die temperature set to 20 C higher than
- * IMX_TEMP_PASSIVE.
+ * Set the default passive cooling trip point to critical - 20C
+ * (can be changed from userspace)
*/
- data->temp_critical = 1000 * 20 + data->temp_passive;
+ data->temp_passive = data->temp_critical - (1000 * 20);
return 0;
}
@@ -559,6 +589,10 @@ static int imx_thermal_probe(struct platform_device *pdev)
return ret;
}
+ dev_info(&pdev->dev, "%s CPU temperature grade - "
+ "thresholds: crit:%ldC passive:%ldC\n", data->temp_grade,
+ data->temp_critical / 1000, data->temp_passive / 1000);
+
/* Enable measurements at ~ 10 Hz */
regmap_write(map, TEMPSENSE1 + REG_CLR, TEMPSENSE1_MEASURE_FREQ);
measure_freq = DIV_ROUND_UP(32768, 10); /* 10 Hz */
--
1.9.1
next reply other threads:[~2015-04-30 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 16:02 Tim Harvey [this message]
2015-05-11 12:22 ` [PATCH] imx: thermal: use CPU temperature grade info for thresholds Shawn Guo
2015-05-11 12:26 ` Fabio Estevam
2015-05-11 13:31 ` Tim Harvey
2015-05-12 1:32 ` Eduardo Valentin
2015-05-11 18:55 ` Fabio Estevam
2015-05-20 22:08 ` Tim Harvey
2015-05-21 23:45 ` [PATCH v2] " Tim Harvey
2015-05-24 2:48 ` Shawn Guo
2015-05-24 5:19 ` Jon Nettleton
2015-05-26 21:24 ` Tim Harvey
2015-05-27 6:08 ` Jon Nettleton
2015-07-28 14:50 ` Tim Harvey
2015-07-28 15:01 ` Jon Nettleton
2015-07-28 16:10 ` Jon Nettleton
2015-07-28 16:12 ` Jon Nettleton
2015-07-30 7:19 ` [PATCH] " Jon Nettleton
2015-10-13 14:16 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430409757-16195-1-git-send-email-tharvey@gateworks.com \
--to=tharvey@gateworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).