linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] clocksource: mediatek: Don't run event_handler if it is NULL
Date: Fri, 1 May 2015 15:43:24 +0800	[thread overview]
Message-ID: <1430466210-22963-2-git-send-email-yingjoe.chen@mediatek.com> (raw)
In-Reply-To: <1430466210-22963-1-git-send-email-yingjoe.chen@mediatek.com>

Spurious timer interrupt is noticed in mtk timer and cause kernel
crash. In mtk_timer_interrupt(), only run event_handler if it is
not NULL.

Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
---
 drivers/clocksource/mtk_timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
index 68ab423..85e0ab5 100644
--- a/drivers/clocksource/mtk_timer.c
+++ b/drivers/clocksource/mtk_timer.c
@@ -143,7 +143,8 @@ static irqreturn_t mtk_timer_interrupt(int irq, void *dev_id)
 
 	/* Acknowledge timer0 irq */
 	writel(GPT_IRQ_ACK(GPT_CLK_EVT), evt->gpt_base + GPT_IRQ_ACK_REG);
-	evt->dev.event_handler(&evt->dev);
+	if (evt->dev.event_handler)
+		evt->dev.event_handler(&evt->dev);
 
 	return IRQ_HANDLED;
 }
-- 
1.8.1.1.dirty

  reply	other threads:[~2015-05-01  7:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  7:43 [PATCH 0/7] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-05-01  7:43 ` Yingjoe Chen [this message]
2015-05-04  8:14   ` [PATCH 1/7] clocksource: mediatek: Don't run event_handler if it is NULL Daniel Lezcano
2015-05-04  8:34     ` Matthias Brugger
2015-05-04  8:44       ` Daniel Lezcano
2015-05-04 15:13         ` Yingjoe Chen
2015-05-01  7:43 ` [PATCH 2/7] clocksource: mediatek: Use GPT as sched clock source Yingjoe Chen
2015-05-01  7:43 ` [PATCH 3/7] arm: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-05-01  7:43 ` [PATCH 4/7] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-05-01  7:43 ` [PATCH 5/7] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-05-06  8:38   ` Matthias Brugger
2015-05-01  7:43 ` [PATCH 6/7] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-05-04  7:08   ` Matthias Brugger
2015-05-04 14:31   ` Sascha Hauer
2015-05-05  5:37     ` Yingjoe Chen
2015-05-01  7:43 ` [PATCH 7/7] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
2015-05-04  7:48 ` [PATCH 0/7] Add SMP bringup support for mt65xx socs Matthias Brugger
2015-05-06  7:19   ` Yingjoe Chen
2015-05-06  7:59     ` Yingjoe Chen
2015-05-06  8:29       ` Matthias Brugger
2015-05-06 11:04         ` Matthias Brugger
2015-05-16  8:09           ` Yingjoe Chen
2015-05-16  9:11             ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430466210-22963-2-git-send-email-yingjoe.chen@mediatek.com \
    --to=yingjoe.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).