linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Add SMP bringup support for mt65xx socs
Date: Wed, 6 May 2015 15:59:42 +0800	[thread overview]
Message-ID: <1430899182.4930.2.camel@mtksdaap41> (raw)
In-Reply-To: <1430896766.15346.13.camel@mtksdaap41>

On Wed, 2015-05-06 at 15:19 +0800, Yingjoe Chen wrote:
> Hi Matthias,
<...>
> > I tried on the mt8135 eval board but it fails to bring up the CPU.
> > 
> > When booting:
> > [    1.048588] CPU1: failed to come online
> > [    2.049914] CPU2: failed to come online
> > [    3.051245] CPU3: failed to come online
> 
> 
> Thanks for testing, and the config file you provided.
> It seems you are running THUMB2 kernel, unfortunately mt8135 trustzone
> firmware doesn't support jump to THUMB2 code directly.
> 
> I can workaround this with the following patch. I'll include it in my
> next round.
> 
> Joe.C
> 
> -----8<----------------
> diff --git a/arch/arm/mach-mediatek/platsmp.c
> b/arch/arm/mach-mediatek/platsmp.c
> index e266b3d..5dea55a 100644
> --- a/arch/arm/mach-mediatek/platsmp.c
> +++ b/arch/arm/mach-mediatek/platsmp.c
> @@ -57,6 +57,18 @@ static const struct of_device_id mtk_smp_boot_infos[]
> __initconst = {
>  static void __iomem *mtk_smp_base;
>  static const struct mtk_smp_boot_info *mtk_smp_info;
>  
> +#ifdef CONFIG_THUMB2_KERNEL
> +__asm__(
> +	".arm\n"
> +	"mtk_secondary_startup_fixup:\n"
> +	"	b secondary_startup\n"
> +	".thumb\n"
> +);
> +
> +void mtk_secondary_startup_fixup(void);
> +#define secondary_startup mtk_secondary_startup_fixup
> +#endif


Replying myself.

It seems kernel already have secondary_startup_arm which support this
usage. I'll use that in my next version instead.

Joe.C

  reply	other threads:[~2015-05-06  7:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  7:43 [PATCH 0/7] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-05-01  7:43 ` [PATCH 1/7] clocksource: mediatek: Don't run event_handler if it is NULL Yingjoe Chen
2015-05-04  8:14   ` Daniel Lezcano
2015-05-04  8:34     ` Matthias Brugger
2015-05-04  8:44       ` Daniel Lezcano
2015-05-04 15:13         ` Yingjoe Chen
2015-05-01  7:43 ` [PATCH 2/7] clocksource: mediatek: Use GPT as sched clock source Yingjoe Chen
2015-05-01  7:43 ` [PATCH 3/7] arm: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-05-01  7:43 ` [PATCH 4/7] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-05-01  7:43 ` [PATCH 5/7] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-05-06  8:38   ` Matthias Brugger
2015-05-01  7:43 ` [PATCH 6/7] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-05-04  7:08   ` Matthias Brugger
2015-05-04 14:31   ` Sascha Hauer
2015-05-05  5:37     ` Yingjoe Chen
2015-05-01  7:43 ` [PATCH 7/7] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
2015-05-04  7:48 ` [PATCH 0/7] Add SMP bringup support for mt65xx socs Matthias Brugger
2015-05-06  7:19   ` Yingjoe Chen
2015-05-06  7:59     ` Yingjoe Chen [this message]
2015-05-06  8:29       ` Matthias Brugger
2015-05-06 11:04         ` Matthias Brugger
2015-05-16  8:09           ` Yingjoe Chen
2015-05-16  9:11             ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430899182.4930.2.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).