linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
Date: Wed, 06 May 2015 13:12:07 +0200	[thread overview]
Message-ID: <1430910727.2473.3.camel@pengutronix.de> (raw)
In-Reply-To: <CALHpu36GENbeCHf-8HDGwX=weCpb5kCzD_02ZAeXOs3NcW-nzA@mail.gmail.com>

Hi Jon,

Am Mittwoch, den 06.05.2015, 13:04 +0200 schrieb Jon Nettleton:
> On Wed, May 6, 2015 at 12:35 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> >
> > On Mon, Apr 27, 2015 at 04:51:57PM +0800, Shawn Guo wrote:
> > > On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> > > > From: Fabio Estevam <fabio.estevam@freescale.com>
> > > >
> > > > Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> > > > tree.
> > > >
> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > Russell,
> > >
> > > Are you fine with this patch?
> >
> > I don't have a view on this because I don't have any experience of PCIe.
> > However, I don't see anything obviously wrong with the patch.
> >
> 
> That patch is fine.  In the SolidRun kernel we are actually using
> 0x80000000 as our pin strength to accept the default value, but I have
> previously tested with 0x1b0b1 and it works as expected.
> 
> I have not tested this with the upstream kernel but previously MSI was
> not working properly on the iMX6 pcie implementation.  This was worked
> around by either disabling the kernel config option, or add pci=nomsi
> to the kernel commandline.  I currently have a patch that takes a
> nomsi device-tree option to workaround this bug.
> 
> Is pcie working with MSI now on the iMX6 hardware?
> 
> -Jon
> 

MSI is working properly on i.MX6 with all devices I had a chance to
test. If you've got some specific devices where it doesn't work with a
mainline kernel I would be interested in receiving bug reports.

It is certainly no hardware limitation, so please don't push a
workaround into DT.

Regards,
Lucas

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

  reply	other threads:[~2015-05-06 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  0:41 [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support Fabio Estevam
2015-04-27  8:51 ` Shawn Guo
2015-05-06 10:35   ` Russell King - ARM Linux
2015-05-06 11:04     ` Jon Nettleton
2015-05-06 11:12       ` Lucas Stach [this message]
2015-05-06 13:47       ` Fabio Estevam
2015-05-07  6:25 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430910727.2473.3.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).