* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
@ 2015-04-09 0:41 Fabio Estevam
2015-04-27 8:51 ` Shawn Guo
2015-05-07 6:25 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-04-09 0:41 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
tree.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index 151a3db..ccdfcfa 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -192,6 +192,12 @@
>;
};
+ pinctrl_hummingboard_pcie_reset: hummingboard-pcie-reset {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_DA4__GPIO3_IO04 0x1b0b1
+ >;
+ };
+
pinctrl_hummingboard_pwm1: pwm1grp {
fsl,pins = <MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b1>;
};
@@ -245,6 +251,13 @@
};
};
+&pcie {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_hummingboard_pcie_reset>;
+ reset-gpio = <&gpio3 4 0>;
+ status = "okay";
+};
+
&pwm1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hummingboard_pwm1>;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-04-09 0:41 [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support Fabio Estevam
@ 2015-04-27 8:51 ` Shawn Guo
2015-05-06 10:35 ` Russell King - ARM Linux
2015-05-07 6:25 ` Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2015-04-27 8:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> tree.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Russell,
Are you fine with this patch?
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> index 151a3db..ccdfcfa 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> @@ -192,6 +192,12 @@
> >;
> };
>
> + pinctrl_hummingboard_pcie_reset: hummingboard-pcie-reset {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_DA4__GPIO3_IO04 0x1b0b1
> + >;
> + };
> +
> pinctrl_hummingboard_pwm1: pwm1grp {
> fsl,pins = <MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b1>;
> };
> @@ -245,6 +251,13 @@
> };
> };
>
> +&pcie {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hummingboard_pcie_reset>;
> + reset-gpio = <&gpio3 4 0>;
> + status = "okay";
> +};
> +
> &pwm1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hummingboard_pwm1>;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-04-27 8:51 ` Shawn Guo
@ 2015-05-06 10:35 ` Russell King - ARM Linux
2015-05-06 11:04 ` Jon Nettleton
0 siblings, 1 reply; 7+ messages in thread
From: Russell King - ARM Linux @ 2015-05-06 10:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 27, 2015 at 04:51:57PM +0800, Shawn Guo wrote:
> On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> > tree.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Russell,
>
> Are you fine with this patch?
I don't have a view on this because I don't have any experience of PCIe.
However, I don't see anything obviously wrong with the patch.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-05-06 10:35 ` Russell King - ARM Linux
@ 2015-05-06 11:04 ` Jon Nettleton
2015-05-06 11:12 ` Lucas Stach
2015-05-06 13:47 ` Fabio Estevam
0 siblings, 2 replies; 7+ messages in thread
From: Jon Nettleton @ 2015-05-06 11:04 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 6, 2015 at 12:35 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
>
> On Mon, Apr 27, 2015 at 04:51:57PM +0800, Shawn Guo wrote:
> > On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> > > From: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> > > tree.
> > >
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Russell,
> >
> > Are you fine with this patch?
>
> I don't have a view on this because I don't have any experience of PCIe.
> However, I don't see anything obviously wrong with the patch.
>
That patch is fine. In the SolidRun kernel we are actually using
0x80000000 as our pin strength to accept the default value, but I have
previously tested with 0x1b0b1 and it works as expected.
I have not tested this with the upstream kernel but previously MSI was
not working properly on the iMX6 pcie implementation. This was worked
around by either disabling the kernel config option, or add pci=nomsi
to the kernel commandline. I currently have a patch that takes a
nomsi device-tree option to workaround this bug.
Is pcie working with MSI now on the iMX6 hardware?
-Jon
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-05-06 11:04 ` Jon Nettleton
@ 2015-05-06 11:12 ` Lucas Stach
2015-05-06 13:47 ` Fabio Estevam
1 sibling, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2015-05-06 11:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jon,
Am Mittwoch, den 06.05.2015, 13:04 +0200 schrieb Jon Nettleton:
> On Wed, May 6, 2015 at 12:35 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> >
> > On Mon, Apr 27, 2015 at 04:51:57PM +0800, Shawn Guo wrote:
> > > On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> > > > From: Fabio Estevam <fabio.estevam@freescale.com>
> > > >
> > > > Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> > > > tree.
> > > >
> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > Russell,
> > >
> > > Are you fine with this patch?
> >
> > I don't have a view on this because I don't have any experience of PCIe.
> > However, I don't see anything obviously wrong with the patch.
> >
>
> That patch is fine. In the SolidRun kernel we are actually using
> 0x80000000 as our pin strength to accept the default value, but I have
> previously tested with 0x1b0b1 and it works as expected.
>
> I have not tested this with the upstream kernel but previously MSI was
> not working properly on the iMX6 pcie implementation. This was worked
> around by either disabling the kernel config option, or add pci=nomsi
> to the kernel commandline. I currently have a patch that takes a
> nomsi device-tree option to workaround this bug.
>
> Is pcie working with MSI now on the iMX6 hardware?
>
> -Jon
>
MSI is working properly on i.MX6 with all devices I had a chance to
test. If you've got some specific devices where it doesn't work with a
mainline kernel I would be interested in receiving bug reports.
It is certainly no hardware limitation, so please don't push a
workaround into DT.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-05-06 11:04 ` Jon Nettleton
2015-05-06 11:12 ` Lucas Stach
@ 2015-05-06 13:47 ` Fabio Estevam
1 sibling, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-05-06 13:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jon,
On Wed, May 6, 2015 at 8:04 AM, Jon Nettleton <jon.nettleton@gmail.com> wrote:
> That patch is fine. In the SolidRun kernel we are actually using
> 0x80000000 as our pin strength to accept the default value, but I have
> previously tested with 0x1b0b1 and it works as expected.
Yes, putting 0x80000000 or 0x1b0b1 has the same effect as 0x1b0b1 is
the default PAD configuration that comes out of reset. I prefer to
pass the value explicitly though.
I tested it with an Intel 7260HMW Wifi card and it worked well.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support
2015-04-09 0:41 [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support Fabio Estevam
2015-04-27 8:51 ` Shawn Guo
@ 2015-05-07 6:25 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2015-05-07 6:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 08, 2015 at 09:41:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Add PCIe support. Based on a patch from Rabeeh Khoury from the solid-run
> tree.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-05-07 6:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-09 0:41 [PATCH] ARM: dts: imx6qdl-hummingboard: Add PCIe support Fabio Estevam
2015-04-27 8:51 ` Shawn Guo
2015-05-06 10:35 ` Russell King - ARM Linux
2015-05-06 11:04 ` Jon Nettleton
2015-05-06 11:12 ` Lucas Stach
2015-05-06 13:47 ` Fabio Estevam
2015-05-07 6:25 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).