linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: stuart.yoder@freescale.com (Stuart Yoder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: GICv3: ITS: don't assume 64K page size in its_alloc_tables
Date: Thu, 14 May 2015 18:02:25 -0500	[thread overview]
Message-ID: <1431644545-31904-1-git-send-email-stuart.yoder@freescale.com> (raw)

its_alloc_tables() needs to account for page sizes other than
64KB.  Without this change, when PAGE_SIZE=4KB its_alloc_tables()
gets stuck in an infinite loop.

Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---

think this should go into 4.1 if at all possible...without it I am
unable to boot a 4.1 kernel on the LS2085 SoC

 drivers/irqchip/irq-gic-v3-its.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 9687f8a..58a6612 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -800,7 +800,7 @@ static int its_alloc_tables(struct its_node *its)
 {
 	int err;
 	int i;
-	int psz = SZ_64K;
+	int psz = PAGE_SIZE;
 	u64 shr = GITS_BASER_InnerShareable;
 	u64 cache = GITS_BASER_WaWb;
 
-- 
2.3.3

             reply	other threads:[~2015-05-14 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 23:02 Stuart Yoder [this message]
2015-05-18 13:23 ` [PATCH] irqchip: GICv3: ITS: don't assume 64K page size in its_alloc_tables Marc Zyngier
2015-05-18 13:38   ` Stuart Yoder
2015-05-18 14:09     ` Marc Zyngier
2015-05-18 15:33       ` Stuart Yoder
2015-05-18 15:36         ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431644545-31904-1-git-send-email-stuart.yoder@freescale.com \
    --to=stuart.yoder@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).