From: shawnguo@kernel.org (shawnguo at kernel.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] ARM: imx: define gpt register offset per device type
Date: Fri, 15 May 2015 16:11:44 +0800 [thread overview]
Message-ID: <1431677507-27420-7-git-send-email-shawnguo@kernel.org> (raw)
In-Reply-To: <1431677507-27420-1-git-send-email-shawnguo@kernel.org>
From: Shawn Guo <shawn.guo@linaro.org>
It initializes offset of gpt registers TSTAT, TCN and TCMP per device
type, so that the access to these registers can be unified.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/mach-imx/time.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-imx/time.c b/arch/arm/mach-imx/time.c
index d79a00e24084..5908e78d9552 100644
--- a/arch/arm/mach-imx/time.c
+++ b/arch/arm/mach-imx/time.c
@@ -91,6 +91,9 @@ struct imx_timer {
int irq;
struct clk *clk_per;
struct clk *clk_ipg;
+ int reg_tstat;
+ int reg_tcn;
+ int reg_tcmp;
void (*gpt_setup_tctl)(void);
};
@@ -147,7 +150,7 @@ static unsigned long imx_read_current_timer(void)
static int __init mxc_clocksource_init(void)
{
unsigned int c = clk_get_rate(imxtm.clk_per);
- void __iomem *reg = imxtm.base + (timer_is_v2() ? V2_TCN : MX1_2_TCN);
+ void __iomem *reg = imxtm.base + imxtm.reg_tcn;
imx_delay_timer.read_current_timer = &imx_read_current_timer;
imx_delay_timer.freq = c;
@@ -214,13 +217,8 @@ static void mxc_set_mode(enum clock_event_mode mode,
gpt_irq_disable();
if (mode != clockevent_mode) {
- /* Set event time into far-far future */
- if (timer_is_v2())
- __raw_writel(__raw_readl(imxtm.base + V2_TCN) - 3,
- imxtm.base + V2_TCMP);
- else
- __raw_writel(__raw_readl(imxtm.base + MX1_2_TCN) - 3,
- imxtm.base + MX1_2_TCMP);
+ __raw_writel(__raw_readl(imxtm.base + imxtm.reg_tcn) - 3,
+ imxtm.base + imxtm.reg_tcmp);
/* Clear pending interrupt */
gpt_irq_acknowledge();
@@ -268,10 +266,7 @@ static irqreturn_t mxc_timer_interrupt(int irq, void *dev_id)
struct clock_event_device *evt = &clockevent_mxc;
uint32_t tstat;
- if (timer_is_v2())
- tstat = __raw_readl(imxtm.base + V2_TSTAT);
- else
- tstat = __raw_readl(imxtm.base + MX1_2_TSTAT);
+ tstat = __raw_readl(imxtm.base + imxtm.reg_tstat);
gpt_irq_acknowledge();
@@ -346,18 +341,30 @@ static void __init imx_timer_data_init(void)
{
switch (imxtm.type) {
case GPT_TYPE_IMX1:
+ imxtm.reg_tstat = MX1_2_TSTAT;
+ imxtm.reg_tcn = MX1_2_TCN;
+ imxtm.reg_tcmp = MX1_2_TCMP;
imxtm.gpt_setup_tctl = imx1_gpt_setup_tctl;
clockevent_mxc.set_next_event = mx1_2_set_next_event;
break;
case GPT_TYPE_IMX21:
+ imxtm.reg_tstat = MX1_2_TSTAT;
+ imxtm.reg_tcn = MX1_2_TCN;
+ imxtm.reg_tcmp = MX1_2_TCMP;
imxtm.gpt_setup_tctl = imx21_gpt_setup_tctl;
clockevent_mxc.set_next_event = mx1_2_set_next_event;
break;
case GPT_TYPE_IMX31:
+ imxtm.reg_tstat = V2_TSTAT;
+ imxtm.reg_tcn = V2_TCN;
+ imxtm.reg_tcmp = V2_TCMP;
imxtm.gpt_setup_tctl = imx31_gpt_setup_tctl;
clockevent_mxc.set_next_event = v2_set_next_event;
break;
case GPT_TYPE_IMX6DL:
+ imxtm.reg_tstat = V2_TSTAT;
+ imxtm.reg_tcn = V2_TCN;
+ imxtm.reg_tcmp = V2_TCMP;
imxtm.gpt_setup_tctl = imx6dl_gpt_setup_tctl;
clockevent_mxc.set_next_event = v2_set_next_event;
break;
--
1.9.1
next prev parent reply other threads:[~2015-05-15 8:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 8:11 [PATCH 0/9] ARM: imx: move timer driver into drivers/clocksource shawnguo at kernel.org
2015-05-15 8:11 ` [PATCH 1/9] ARM: imx: move timer resources into a structure shawnguo at kernel.org
2015-05-15 16:36 ` Shenwei Wang
2015-05-19 7:57 ` Shawn Guo
2015-05-18 10:43 ` Daniel Lezcano
2015-05-19 7:58 ` Shawn Guo
2015-05-15 8:11 ` [PATCH 2/9] ARM: imx: define an enum for gpt timer device type shawnguo at kernel.org
2015-05-15 16:30 ` Shenwei Wang
2015-05-15 8:11 ` [PATCH 3/9] ARM: imx: initialize gpt device type for DT boot shawnguo at kernel.org
2015-05-15 8:11 ` [PATCH 4/9] ARM: imx: setup tctl register in device specific function shawnguo at kernel.org
2015-05-15 8:35 ` Arnd Bergmann
2015-05-19 8:08 ` Shawn Guo
2015-05-15 8:11 ` [PATCH 5/9] ARM: imx: set up set_next_event hook in imx_timer_data_init() shawnguo at kernel.org
2015-05-15 8:11 ` shawnguo at kernel.org [this message]
2015-05-15 8:34 ` [PATCH 6/9] ARM: imx: define gpt register offset per device type Arnd Bergmann
2015-05-19 8:09 ` Shawn Guo
2015-05-15 8:11 ` [PATCH 7/9] ARM: imx: provide gpt device specific irq functions shawnguo at kernel.org
2015-05-15 8:11 ` [PATCH 8/9] ARM: imx: remove platform headers from timer driver shawnguo at kernel.org
2015-05-15 8:11 ` [PATCH 9/9] ARM: imx: move timer driver into drivers/clocksource shawnguo at kernel.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431677507-27420-7-git-send-email-shawnguo@kernel.org \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).