From: stuart.yoder@freescale.com (Stuart Yoder)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][ PATCH v3] irqchip/gicv3-its: ITS table size should not be smaller than PSZ
Date: Wed, 20 May 2015 10:13:15 -0500 [thread overview]
Message-ID: <1432134795-661-1-git-send-email-stuart.yoder@freescale.com> (raw)
when allocating a device table, if the requested allocation
is smaller than the default granule size of the ITS
then, we need to round up to the default size
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
-v3 changes
-updated commit message and added comment
-v3 resend-- updated email addresses sent to
-would be nice to get this into 4.1 as the kernel will hang booting
on some systems
drivers/irqchip/irq-gic-v3-its.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 9687f8a..1b7e155 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -828,7 +828,14 @@ static int its_alloc_tables(struct its_node *its)
u64 typer = readq_relaxed(its->base + GITS_TYPER);
u32 ids = GITS_TYPER_DEVBITS(typer);
- order = get_order((1UL << ids) * entry_size);
+ /*
+ * 'order' was initialized earlier to the default page
+ * granule of the the ITS. We can't have an allocation
+ * smaller than that. If the requested allocation
+ * is smaller, round up to the default page granule.
+ */
+ order = max(get_order((1UL << ids) * entry_size),
+ order);
if (order >= MAX_ORDER) {
order = MAX_ORDER - 1;
pr_warn("%s: Device Table too large, reduce its page order to %u\n",
--
2.3.3
next reply other threads:[~2015-05-20 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:13 Stuart Yoder [this message]
2015-05-20 19:25 ` [RESEND][ PATCH v3] irqchip/gicv3-its: ITS table size should not be smaller than PSZ Thomas Gleixner
2015-05-20 19:54 ` Stuart Yoder
2015-05-20 20:03 ` Jason Cooper
2015-05-20 20:09 ` Thomas Gleixner
2015-05-20 20:11 ` Stuart Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432134795-661-1-git-send-email-stuart.yoder@freescale.com \
--to=stuart.yoder@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).