From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] i2c: pxa: Add pin ctrl support for CP core access
Date: Thu, 28 May 2015 19:02:48 +0530 [thread overview]
Message-ID: <1432819968-17515-4-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1432819968-17515-1-git-send-email-vaibhav.hiremath@linaro.org>
PMIC TWSI pins configuration for AP and CP is different on
eden, it need to be set to function 0 when AP get RIPC lock.
When AP release RIPC lock, it also need configure twsi pins
to other state, otherwise pinctrl will assume pins configration
is not changed even if it is changed by CP, so it will not
change twsi pins configuration to AP state when AP get RIPC
next time.
Signed-off-by: Shouming Wang <wangshm@marvell.com>
Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
drivers/i2c/busses/i2c-pxa.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index eb26eb1..1340de1 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -184,6 +184,7 @@ struct pxa_i2c {
struct pinctrl *pinctrl;
struct pinctrl_state *pin_i2c;
struct pinctrl_state *pin_gpio;
+ struct pinctrl_state *pin_i2c_cp;
};
#define _IBMR(i2c) ((i2c)->reg_ibmr)
@@ -405,6 +406,10 @@ void mmp_hwlock_lock(struct i2c_adapter *adap)
ripc_status = true;
spin_unlock_irqrestore(&lock_for_ripc, flags);
+
+ if (pinctrl_select_state(i2c->pinctrl, i2c->pin_i2c) < 0)
+ dev_err(&i2c->adap.dev, "could not set i2c AP pins\n");
+
}
void mmp_hwlock_unlock(struct i2c_adapter *adap)
@@ -413,6 +418,9 @@ void mmp_hwlock_unlock(struct i2c_adapter *adap)
struct pxa_i2c *i2c = adap->algo_data;
+ if (pinctrl_select_state(i2c->pinctrl, i2c->pin_i2c_cp) < 0)
+ dev_err(&i2c->adap.dev, "could not set i2c CP pins\n");
+
spin_lock_irqsave(&lock_for_ripc, flags);
__raw_writel(1, i2c->hwlock_addr);
ripc_status = false;
@@ -430,6 +438,9 @@ int mmp_hwlock_trylock(struct i2c_adapter *adap)
ripc_status = !__raw_readl(i2c->hwlock_addr);
spin_unlock_irqrestore(&lock_for_ripc, flags);
+ if (ripc_status && (pinctrl_select_state(i2c->pinctrl, i2c->pin_i2c) < 0))
+ dev_err(&i2c->adap.dev, "could not set i2c AP pins\n");
+
return ripc_status;
}
@@ -1497,8 +1508,14 @@ static int i2c_pxa_probe(struct platform_device *dev)
ret = IS_ERR(i2c->pin_gpio);
}
+ /* pin ctrl for CP - optional */
+ i2c->pin_i2c_cp = pinctrl_lookup_state(i2c->pinctrl, "i2c_cp");
+ if (IS_ERR(i2c->pin_i2c_cp))
+ dev_err(&dev->dev, "could not get i2c_cp pinstate\n");
+
if (ret) {
i2c->pin_i2c = NULL;
+ i2c->pin_i2c_cp = NULL;
i2c->pin_gpio = NULL;
i2c->pinctrl = NULL;
ret = 0;
--
1.9.1
prev parent reply other threads:[~2015-05-28 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 13:32 [PATCH 0/3] i2c: core/pxa: Add support for hardware lock Vaibhav Hiremath
2015-05-28 13:32 ` [PATCH 1/3] i2c: core: append hardware lock with bus lock Vaibhav Hiremath
2015-05-28 13:32 ` [PATCH 2/3] i2c: pxa: Add support for hardware lock Vaibhav Hiremath
2015-05-28 13:32 ` Vaibhav Hiremath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432819968-17515-4-git-send-email-vaibhav.hiremath@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).