* [PATCH] KVM: arm: vgic: Drop useless Group0 warning
@ 2015-05-29 16:30 Marc Zyngier
2015-06-01 10:05 ` Christoffer Dall
0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2015-05-29 16:30 UTC (permalink / raw)
To: linux-arm-kernel
If a GICv3-enabled guest tries to configure Group0, we print a
warning on the console (because we don't support Group0 interrupts).
This is fairly pointless, and would allow a guest to spam the
console. Let's just drop the warning.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
virt/kvm/arm/vgic-v3-emul.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/virt/kvm/arm/vgic-v3-emul.c b/virt/kvm/arm/vgic-v3-emul.c
index e9c3a7a..53e6a6d 100644
--- a/virt/kvm/arm/vgic-v3-emul.c
+++ b/virt/kvm/arm/vgic-v3-emul.c
@@ -76,8 +76,6 @@ static bool handle_mmio_ctlr(struct kvm_vcpu *vcpu,
vgic_reg_access(mmio, ®, offset,
ACCESS_READ_VALUE | ACCESS_WRITE_VALUE);
if (mmio->is_write) {
- if (reg & GICD_CTLR_ENABLE_SS_G0)
- kvm_info("guest tried to enable unsupported Group0 interrupts\n");
vcpu->kvm->arch.vgic.enabled = !!(reg & GICD_CTLR_ENABLE_SS_G1);
vgic_update_state(vcpu->kvm);
return true;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] KVM: arm: vgic: Drop useless Group0 warning
2015-05-29 16:30 [PATCH] KVM: arm: vgic: Drop useless Group0 warning Marc Zyngier
@ 2015-06-01 10:05 ` Christoffer Dall
0 siblings, 0 replies; 2+ messages in thread
From: Christoffer Dall @ 2015-06-01 10:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 29, 2015 at 05:30:15PM +0100, Marc Zyngier wrote:
> If a GICv3-enabled guest tries to configure Group0, we print a
> warning on the console (because we don't support Group0 interrupts).
>
> This is fairly pointless, and would allow a guest to spam the
> console. Let's just drop the warning.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-01 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-29 16:30 [PATCH] KVM: arm: vgic: Drop useless Group0 warning Marc Zyngier
2015-06-01 10:05 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).