linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] regulator: pwm-regulator: Remove unnecessary descriptor attribute from ddata
Date: Fri,  5 Jun 2015 19:42:45 +0100	[thread overview]
Message-ID: <1433529771-24496-3-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1433529771-24496-1-git-send-email-lee.jones@linaro.org>

The Regulator Device keeps a full copy of it's own, which can be easily accessed.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/regulator/pwm-regulator.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index cf2a39b..4a071b6 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -21,7 +21,6 @@
 #include <linux/pwm.h>
 
 struct pwm_regulator_data {
-	struct regulator_desc desc;
 	struct pwm_voltages *duty_cycle_table;
 	struct pwm_device *pwm;
 	bool enabled;
@@ -78,7 +77,7 @@ static int pwm_regulator_list_voltage(struct regulator_dev *dev,
 {
 	struct pwm_regulator_data *drvdata = rdev_get_drvdata(dev);
 
-	if (selector >= drvdata->desc.n_voltages)
+	if (selector >= dev->desc->n_voltages)
 		return -EINVAL;
 
 	return drvdata->duty_cycle_table[selector].uV;
@@ -91,7 +90,7 @@ static struct regulator_ops pwm_regulator_voltage_ops = {
 	.map_voltage     = regulator_map_voltage_iterate,
 };
 
-static const struct regulator_desc pwm_regulator_desc = {
+static struct regulator_desc pwm_regulator_desc = {
 	.name		= "pwm-regulator",
 	.ops		= &pwm_regulator_voltage_ops,
 	.type		= REGULATOR_VOLTAGE,
@@ -117,8 +116,6 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 	if (!drvdata)
 		return -ENOMEM;
 
-	memcpy(&drvdata->desc, &pwm_regulator_desc, sizeof(pwm_regulator_desc));
-
 	/* determine the number of voltage-table */
 	prop = of_find_property(np, "voltage-table", &length);
 	if (!prop) {
@@ -133,7 +130,7 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	drvdata->desc.n_voltages = length / sizeof(*drvdata->duty_cycle_table);
+	pwm_regulator_desc.n_voltages = length / sizeof(*drvdata->duty_cycle_table);
 
 	drvdata->duty_cycle_table = devm_kzalloc(&pdev->dev,
 						 length, GFP_KERNEL);
@@ -150,7 +147,7 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 	}
 
 	config.init_data = of_get_regulator_init_data(&pdev->dev, np,
-						      &drvdata->desc);
+						      &pwm_regulator_desc);
 	if (!config.init_data)
 		return -ENOMEM;
 
@@ -165,10 +162,10 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 	}
 
 	regulator = devm_regulator_register(&pdev->dev,
-					    &drvdata->desc, &config);
+					    &pwm_regulator_desc, &config);
 	if (IS_ERR(regulator)) {
 		dev_err(&pdev->dev, "Failed to register regulator %s\n",
-			drvdata->desc.name);
+			pwm_regulator_desc.name);
 		return PTR_ERR(regulator);
 	}
 
-- 
1.9.1

  parent reply	other threads:[~2015-06-05 18:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 18:42 [PATCH 0/8] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-06-05 18:42 ` [PATCH 1/8] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-06-05 18:42 ` Lee Jones [this message]
2015-06-08 18:11   ` [PATCH 2/8] regulator: pwm-regulator: Remove unnecessary descriptor attribute from ddata Mark Brown
2015-06-05 18:42 ` [PATCH 3/8] regulator: pwm-regulator: Remove superfluous is_enabled check Lee Jones
2015-06-08 18:11   ` Mark Brown
2015-06-05 18:42 ` [PATCH 4/8] regulator: pwm-regulator: Diffientiate between dev (device) and rdev (regulator_dev) Lee Jones
2015-06-08 18:11   ` Mark Brown
2015-06-05 18:42 ` [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-06-08 18:07   ` Mark Brown
2015-06-09  7:03     ` Lee Jones
2015-06-09 10:10       ` Mark Brown
2015-06-09 11:07         ` Lee Jones
2015-06-05 18:42 ` [PATCH 6/8] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-06-09 17:14   ` Mark Brown
2015-06-10  7:58     ` Lee Jones
2015-06-05 18:42 ` [PATCH 7/8] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-06-05 18:42 ` [PATCH 8/8] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-06-05 18:47   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433529771-24496-3-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).