linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] regulator: pwm-regulator: Remove superfluous is_enabled check
Date: Fri,  5 Jun 2015 19:42:46 +0100	[thread overview]
Message-ID: <1433529771-24496-4-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1433529771-24496-1-git-send-email-lee.jones@linaro.org>

The core framework already takes care of this.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/regulator/pwm-regulator.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index 4a071b6..36f9684 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -23,7 +23,6 @@
 struct pwm_regulator_data {
 	struct pwm_voltages *duty_cycle_table;
 	struct pwm_device *pwm;
-	bool enabled;
 	int state;
 };
 
@@ -60,13 +59,10 @@ static int pwm_regulator_set_voltage_sel(struct regulator_dev *dev,
 
 	drvdata->state = selector;
 
-	if (!drvdata->enabled) {
-		ret = pwm_enable(drvdata->pwm);
-		if (ret) {
-			dev_err(&dev->dev, "Failed to enable PWM\n");
-			return ret;
-		}
-		drvdata->enabled = true;
+	ret = pwm_enable(drvdata->pwm);
+	if (ret) {
+		dev_err(&dev->dev, "Failed to enable PWM\n");
+		return ret;
 	}
 
 	return 0;
-- 
1.9.1

  parent reply	other threads:[~2015-06-05 18:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 18:42 [PATCH 0/8] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-06-05 18:42 ` [PATCH 1/8] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-06-05 18:42 ` [PATCH 2/8] regulator: pwm-regulator: Remove unnecessary descriptor attribute from ddata Lee Jones
2015-06-08 18:11   ` Mark Brown
2015-06-05 18:42 ` Lee Jones [this message]
2015-06-08 18:11   ` [PATCH 3/8] regulator: pwm-regulator: Remove superfluous is_enabled check Mark Brown
2015-06-05 18:42 ` [PATCH 4/8] regulator: pwm-regulator: Diffientiate between dev (device) and rdev (regulator_dev) Lee Jones
2015-06-08 18:11   ` Mark Brown
2015-06-05 18:42 ` [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-06-08 18:07   ` Mark Brown
2015-06-09  7:03     ` Lee Jones
2015-06-09 10:10       ` Mark Brown
2015-06-09 11:07         ` Lee Jones
2015-06-05 18:42 ` [PATCH 6/8] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-06-09 17:14   ` Mark Brown
2015-06-10  7:58     ` Lee Jones
2015-06-05 18:42 ` [PATCH 7/8] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-06-05 18:42 ` [PATCH 8/8] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-06-05 18:47   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433529771-24496-4-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).