From: wxt@rock-chips.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state
Date: Tue, 9 Jun 2015 17:49:58 +0800 [thread overview]
Message-ID: <1433843400-24831-3-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1433843400-24831-1-git-send-email-wxt@rock-chips.com>
The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die()
executed in time.
The mdelay(1) has enough time to fix the problem of CPU offlining.
That's a workaround way in rockchip hotplug code,
At least, we haven't a better way to solve it. Who know,
that maybe fixed by chip (hardware) in the future.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---
Changes in v6:
- Fix the delay 1ms describing.
Series-changes: 5
- Fix the patch decription.
- Add the changelog.
Series-changes: 2
- As Kever points out, Fix the subject typo WFI/WFE.
arch/arm/mach-rockchip/platsmp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index b379cc8..d629206 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -322,6 +322,13 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
#ifdef CONFIG_HOTPLUG_CPU
static int rockchip_cpu_kill(unsigned int cpu)
{
+ /*
+ * We need a delay here to ensure that the dying CPU can finish
+ * executing v7_coherency_exit() and reach the WFI/WFE state
+ * prior to having the power domain disabled.
+ */
+ mdelay(1);
+
pmu_set_power_domain(0 + cpu, false);
return 1;
}
--
1.9.1
next prev parent reply other threads:[~2015-06-09 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:49 [PATCH v6 0/3] ARM: rockchip: fix the SMP Caesar Wang
2015-06-09 9:49 ` [PATCH v6 1/3] ARM: rockchip: fix the CPU soft reset Caesar Wang
2015-06-09 18:16 ` Doug Anderson
2015-06-10 5:58 ` Kever Yang
2015-06-09 9:49 ` Caesar Wang [this message]
2015-06-09 18:13 ` [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state Doug Anderson
2015-06-10 5:59 ` Kever Yang
2015-06-09 9:49 ` [PATCH v6 3/3] ARM: rockchip: fix the SMP code style Caesar Wang
2015-06-09 18:17 ` Doug Anderson
2015-06-10 5:59 ` Kever Yang
2015-06-09 20:04 ` [PATCH v6 0/3] ARM: rockchip: fix the SMP Heiko Stübner
2015-06-13 21:02 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433843400-24831-3-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).