public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] msm_serial: Add devicetree support
Date: Sat, 13 Aug 2011 10:29 +0200	[thread overview]
Message-ID: <1434305.ibxmc6q715@wuerfel> (raw)
In-Reply-To: <1313190008-7551-3-git-send-email-davidb@codeaurora.org>

On Friday 12 August 2011 16:00:06 David Brown wrote:
> +Required properties:
> +- compatible :
> +       - "qcom,msm-uart"
> +- reg : offset and length of the register set for the device
> +       for the hsuart operating in compatible mode, there should be a
> +       second pair describing the gsbi registers.
> +- interrupts : should contain the uart interrupt.
> +
> +Example:
> +
> +       uart at 19c400000 {
> +               compatible = "qcom,msm-hsuart", "qcom,msm-uart";
> +               reg = <0x19c40000 0x1000">,
> +                     <0x19c00000 0x1000">;
> +               interrupts = <195>;
> +       };



> @@ -920,11 +928,17 @@ static int __devexit msm_serial_remove(struct platform_device *pdev)
>         return 0;
>  }
>  
> +static struct of_device_id msm_match_table[] = {
> +       { .compatible = "qcom,msm-hsuart-lite" },
> +       {}
> +};
> +

Hi David,

It looks like you changed the value for the "compatible" property in the
process of making the patch, but did not update all places.

Should it be qcom,msm-hsuart-lite or qcom,msm-hsuart?

	Arnd

  reply	other threads:[~2011-08-13  8:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 23:00 [PATCH 0/4] Initial DT support for MSM8660 David Brown
2011-08-12 23:00 ` [PATCH 1/4] msm_serial: Use relative resources for iomem David Brown
2011-08-12 23:00 ` [PATCH 2/4] msm_serial: Add devicetree support David Brown
2011-08-13  8:29   ` Arnd Bergmann [this message]
2011-08-13 19:46     ` David Brown
2011-08-13 21:34       ` Arnd Bergmann
2011-08-16 17:57         ` David Brown
2011-08-16 19:07           ` Arnd Bergmann
2011-08-12 23:00 ` [PATCH 3/4] ARM: msm: Add devicetree support for msm8660-surf David Brown
2011-08-12 23:00 ` [PATCH 4/4] ARM: msm: Describe MSM 8660 SURF FPGA registers in DT David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434305.ibxmc6q715@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox