From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver
Date: Mon, 15 Jun 2015 17:00:19 +0200 [thread overview]
Message-ID: <1434380419.2069.38.camel@x220> (raw)
In-Reply-To: <1434258820-26779-4-git-send-email-wxt@rock-chips.com>
On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:
> --- /dev/null
> +++ b/drivers/soc/rockchip/Kconfig
> +config PM_GENERIC_DOMAINS
> + tristate "Rockchip generic power domain"
Since my remarks on v13 you removed the module specific code from
pm_domains.c. But now this became a tristate symbol. That makes little
sense. Why didn't you keep bool?
> + depends on PM
> + help
> + Say y here to enable power doamin support.
s/doamin/domain/.
> + In order to meet high performance and low power requirements, a power
> + management unit is designed or saving power when RK3288 in low power
> + mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.
s/ot/of/
> + If unsure, say N.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-06-15 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 5:13 [PATCH v15 0/4] ARM: rk3288: Add PM Domain support Caesar Wang
2015-06-14 5:13 ` [PATCH v15 1/4] dt-bindings: add document of Rockchip power domain Caesar Wang
2015-06-14 5:13 ` [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver Caesar Wang
2015-06-15 15:00 ` Paul Bolle [this message]
2015-06-16 2:00 ` Caesar Wang
2015-06-14 5:13 ` [PATCH v15 4/4] ARM: dts: add RK3288 power-domain node Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434380419.2069.38.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).