From mboxrd@z Thu Jan 1 00:00:00 1970 From: pebolle@tiscali.nl (Paul Bolle) Date: Thu, 18 Jun 2015 09:12:36 +0200 Subject: [PATCH] clk: at91: add generated clock driver In-Reply-To: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> References: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> Message-ID: <1434611556.2385.8.camel@x220> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote: > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > +config HAVE_AT91_GENERATED > + bool This will always be 'n'. > --- a/drivers/clk/at91/Makefile > +++ b/drivers/clk/at91/Makefile > +obj-$(CONFIG_HAVE_AT91_GENERATED) += clk-generated.o And clk-generated.o will never be built. I think your options are to use config HAVE_AT91_GENERATED def_bool y or config HAVE_AT91_GENERATED bool "Yadda yadda yadda" or add select HAVE_AT91_GENERATED somewhere (possibly even in a second patch). But as it stands the patch looks like an elaborate NOP. Thanks, Paul Bolle