From: tremyfr@gmail.com (Philippe Reynes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] rtc: mxc: use a second rtc clock
Date: Sat, 20 Jun 2015 16:15:29 +0200 [thread overview]
Message-ID: <1434809732-8996-4-git-send-email-tremyfr@gmail.com> (raw)
In-Reply-To: <1434809732-8996-1-git-send-email-tremyfr@gmail.com>
The mxc RTC needs two clocks, one for the input
reference, and one for the IP. But this driver
was only using one clock (for the reference).
This patch add the second clock (for the IP).
Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
drivers/rtc/rtc-mxc.c | 26 +++++++++++++++++---------
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index 09d422b..e916a91 100644
--- a/drivers/rtc/rtc-mxc.c
+++ b/drivers/rtc/rtc-mxc.c
@@ -79,7 +79,8 @@ struct rtc_plat_data {
struct rtc_device *rtc;
void __iomem *ioaddr;
int irq;
- struct clk *clk;
+ struct clk *clk_rtc;
+ struct clk *clk_ipg;
struct rtc_time g_rtc_alarm;
enum imx_rtc_type devtype;
};
@@ -373,17 +374,24 @@ static int mxc_rtc_probe(struct platform_device *pdev)
if (IS_ERR(pdata->ioaddr))
return PTR_ERR(pdata->ioaddr);
- pdata->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(pdata->clk)) {
- dev_err(&pdev->dev, "unable to get clock!\n");
- return PTR_ERR(pdata->clk);
+ pdata->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
+ if (IS_ERR(pdata->clk_ipg)) {
+ dev_err(&pdev->dev, "unable to get ipg clock!\n");
+ return PTR_ERR(pdata->clk_ipg);
}
- ret = clk_prepare_enable(pdata->clk);
+ ret = clk_prepare_enable(pdata->clk_ipg);
if (ret)
return ret;
- rate = clk_get_rate(pdata->clk);
+ pdata->clk_rtc = devm_clk_get(&pdev->dev, "rtc");
+ if (IS_ERR(pdata->clk_rtc)) {
+ dev_err(&pdev->dev, "unable to get rtc clock!\n");
+ ret = PTR_ERR(pdata->clk_rtc);
+ goto exit_put_clk;
+ }
+
+ rate = clk_get_rate(pdata->clk_rtc);
if (rate == 32768)
reg = RTC_INPUT_CLK_32768HZ;
@@ -432,7 +440,7 @@ static int mxc_rtc_probe(struct platform_device *pdev)
return 0;
exit_put_clk:
- clk_disable_unprepare(pdata->clk);
+ clk_disable_unprepare(pdata->clk_ipg);
return ret;
}
@@ -441,7 +449,7 @@ static int mxc_rtc_remove(struct platform_device *pdev)
{
struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
- clk_disable_unprepare(pdata->clk);
+ clk_disable_unprepare(pdata->clk_ipg);
return 0;
}
--
1.7.4.4
next prev parent reply other threads:[~2015-06-20 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 14:15 [PATCH v2 0/6] add device tree support for mxc rtc Philippe Reynes
2015-06-20 14:15 ` [PATCH v2 1/6] imx31: add a second rtc clock Philippe Reynes
2015-06-20 14:15 ` [PATCH v2 2/6] imx35: define two clocks for rtc Philippe Reynes
2015-06-20 14:43 ` Fabio Estevam
2015-06-20 16:48 ` Philippe Reynes
2015-06-20 14:15 ` Philippe Reynes [this message]
2015-06-20 14:15 ` [PATCH v2 4/6] rtc: mxc: add support of device tree Philippe Reynes
2015-06-20 14:15 ` [PATCH v2 5/6] dt-binding: document the binding for mxc rtc Philippe Reynes
2015-06-20 14:15 ` [PATCH v2 6/6] apf27: dt: add support of internal rtc Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434809732-8996-4-git-send-email-tremyfr@gmail.com \
--to=tremyfr@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).