From: geert+renesas@glider.be (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] pinctrl: sh-pfc: Move sh_pfc_add_gpiochip() up
Date: Tue, 30 Jun 2015 09:45:26 +0200 [thread overview]
Message-ID: <1435650327-2542-7-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1435650327-2542-1-git-send-email-geert+renesas@glider.be>
Move sh_pfc_add_gpiochip() to the generic helper section at the top of
the file, so it can be called from the "Function GPIOs" section later.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/sh-pfc/gpio.c | 58 +++++++++++++++++++++----------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c
index b8929b5e2fa26c53..30654e800580524d 100644
--- a/drivers/pinctrl/sh-pfc/gpio.c
+++ b/drivers/pinctrl/sh-pfc/gpio.c
@@ -131,6 +131,35 @@ static int gpio_setup_data_regs(struct sh_pfc_chip *chip)
return 0;
}
+static struct sh_pfc_chip *
+sh_pfc_add_gpiochip(struct sh_pfc *pfc, int(*setup)(struct sh_pfc_chip *),
+ struct sh_pfc_window *mem)
+{
+ struct sh_pfc_chip *chip;
+ int ret;
+
+ chip = devm_kzalloc(pfc->dev, sizeof(*chip), GFP_KERNEL);
+ if (unlikely(!chip))
+ return ERR_PTR(-ENOMEM);
+
+ chip->mem = mem;
+ chip->pfc = pfc;
+
+ ret = setup(chip);
+ if (ret < 0)
+ return ERR_PTR(ret);
+
+ ret = gpiochip_add(&chip->gpio_chip);
+ if (unlikely(ret < 0))
+ return ERR_PTR(ret);
+
+ dev_info(pfc->dev, "%s handling gpio %u -> %u\n",
+ chip->gpio_chip.label, chip->gpio_chip.base,
+ chip->gpio_chip.base + chip->gpio_chip.ngpio - 1);
+
+ return chip;
+}
+
/* -----------------------------------------------------------------------------
* Pin GPIOs
*/
@@ -305,35 +334,6 @@ static int gpio_function_setup(struct sh_pfc_chip *chip)
* Register/unregister
*/
-static struct sh_pfc_chip *
-sh_pfc_add_gpiochip(struct sh_pfc *pfc, int(*setup)(struct sh_pfc_chip *),
- struct sh_pfc_window *mem)
-{
- struct sh_pfc_chip *chip;
- int ret;
-
- chip = devm_kzalloc(pfc->dev, sizeof(*chip), GFP_KERNEL);
- if (unlikely(!chip))
- return ERR_PTR(-ENOMEM);
-
- chip->mem = mem;
- chip->pfc = pfc;
-
- ret = setup(chip);
- if (ret < 0)
- return ERR_PTR(ret);
-
- ret = gpiochip_add(&chip->gpio_chip);
- if (unlikely(ret < 0))
- return ERR_PTR(ret);
-
- dev_info(pfc->dev, "%s handling gpio %u -> %u\n",
- chip->gpio_chip.label, chip->gpio_chip.base,
- chip->gpio_chip.base + chip->gpio_chip.ngpio - 1);
-
- return chip;
-}
-
int sh_pfc_register_gpiochip(struct sh_pfc *pfc)
{
struct sh_pfc_chip *chip;
--
1.9.1
next prev parent reply other threads:[~2015-06-30 7:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 7:45 [PATCH 0/7] ARM: shmobile: Move gpio ranges from C code to DT Geert Uytterhoeven
2015-06-30 7:45 ` [PATCH 1/7] ARM: shmobile: r8a73a4 dtsi: Add missing "gpio-ranges" to gpio node Geert Uytterhoeven
2015-06-30 9:49 ` Laurent Pinchart
2015-07-14 12:05 ` Geert Uytterhoeven
2015-07-16 9:42 ` Linus Walleij
2015-06-30 7:45 ` [PATCH 2/7] ARM: shmobile: r8a7740 " Geert Uytterhoeven
2015-06-30 9:41 ` Laurent Pinchart
2015-06-30 7:45 ` [PATCH 3/7] ARM: shmobile: sh73a0 " Geert Uytterhoeven
2015-06-30 9:48 ` Laurent Pinchart
2015-06-30 7:45 ` [PATCH 4/7] pinctrl: sh-pfc: Stop calling gpiochip_add_pin_range() on DT platforms Geert Uytterhoeven
2015-06-30 9:30 ` Laurent Pinchart
2015-06-30 9:44 ` Geert Uytterhoeven
2015-06-30 9:54 ` Laurent Pinchart
2015-06-30 7:45 ` [PATCH 5/7] pinctrl: sh-pfc: Remove empty gpio_function_free() Geert Uytterhoeven
2015-06-30 9:34 ` Laurent Pinchart
2015-06-30 7:45 ` Geert Uytterhoeven [this message]
2015-06-30 9:35 ` [PATCH 6/7] pinctrl: sh-pfc: Move sh_pfc_add_gpiochip() up Laurent Pinchart
2015-06-30 7:45 ` [PATCH 7/7] pinctrl: sh-pfc: Confine legacy function GPIOs to SH Geert Uytterhoeven
2015-06-30 9:38 ` Laurent Pinchart
2015-06-30 9:48 ` Geert Uytterhoeven
2015-07-16 9:00 ` [PATCH 0/7] ARM: shmobile: Move gpio ranges from C code to DT Linus Walleij
2015-07-16 9:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435650327-2542-7-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).