public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jamesjj.liao@mediatek.com (James Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: mt8173: add clock_null
Date: Thu, 2 Jul 2015 11:06:19 +0800	[thread overview]
Message-ID: <1435806379.3526.31.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBdz2df7ykYpx5Gh1B2Ym+XhpOPOOUu0a_qg7tJKqOy6A@mail.gmail.com>

Hi Daniel,

On Wed, 2015-07-01 at 19:54 +0800, Daniel Kurtz wrote:
> On Wed, Jul 1, 2015 at 2:49 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > The problem is not that you use fixed clocks for non software
> > controllable clocks of unknwown rates, but that you try to use a single
> > clock for all of them and name it 'dummy' or 'null'. Name it
> >
> > dpi_ck {
> >         compatible = "fixed-clock";
> >         rate = <0>; /* unknown, generated by some Analog block */
> > };
> 
> It would be nice, though, to use the real clock rates.
> Otherwise, we end up with a bunch of unknown clock rates, like this:
> 
>    clock                         enable_cnt  prepare_cnt        rate
> accuracy   phase
> ----------------------------------------------------------------------------------------
>  clk_null                                 2            2           0
>        0 0
>     mm_lvds_cts                           0            0           0
>        0 0
>     mm_lvds_pixel                         0            0           0
>        0 0
>     mm_dpi1_pixel                         0            0           0
>        0 0

> Furthermore, at least some of these children clocks are possible
> source clocks for other clocks for which we do want to know the
> resulting frequency.  For example, the "dmpll_*" clocks are mux inputs
> for many of the subsystem clocks.

These clocks such as clkph_mck_o are configured by other modules before
kernel init, and their rates may different among platforms. So we can't
use a hard-coded rate for them. And we also don't care the actual rate
of these clocks, so assign a dummy rate such as 0 to them should be a
better way.


Best regards,

james

  reply	other threads:[~2015-07-02  3:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18  5:29 [PATCH] arm64: dts: mt8173: add clock_null Eddie Huang
2015-06-18 16:15 ` Heiko Stuebner
2015-06-19 11:36   ` Heiko Stuebner
2015-06-22  3:38     ` James Liao
2015-06-22 12:53       ` Heiko Stübner
2015-06-24  7:54         ` James Liao
2015-06-24 10:24           ` Heiko Stübner
2015-06-30  9:07             ` James Liao
2015-07-01  6:49               ` Sascha Hauer
2015-07-01 11:54                 ` Daniel Kurtz
2015-07-02  3:06                   ` James Liao [this message]
2015-07-02  4:23                     ` Daniel Kurtz
2015-07-03  7:45                       ` James Liao
2015-07-03  8:38                         ` Heiko Stübner
2015-07-02  2:05                 ` James Liao
2015-07-07 13:07 ` Sascha Hauer
2015-07-07 14:15   ` Daniel Kurtz
2015-07-07 14:36     ` Sascha Hauer
2015-07-07 15:10       ` Daniel Kurtz
2015-07-08  2:37         ` Eddie Huang
2015-07-08  5:44           ` Sascha Hauer
2015-07-10  7:27             ` Eddie Huang
2015-07-10  8:11               ` Daniel Kurtz
2015-07-10 10:29                 ` Eddie Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435806379.3526.31.camel@mtksdaap41 \
    --to=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox