linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eddie.huang@mediatek.com (Eddie Huang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc-mt6397: enable wakeup before registering rtc device
Date: Thu, 2 Jul 2015 16:49:15 +0800	[thread overview]
Message-ID: <1435826955.21679.2.camel@mtksdaap41> (raw)
In-Reply-To: <1435826216-11982-1-git-send-email-wnhuang@google.com>

On Thu, 2015-07-02 at 16:36 +0800, Wei-Ning Huang wrote:
> rtc_sysfs_add_device checks if device can wakeup before creating the
> wakealarm file in sysfs. Thus the driver must set wakeup capability
> before registering the rtc device.
> 
> Signed-off-by: Wei-Ning Huang <wnhuang@google.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index c0090b6..eab230b 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -343,6 +343,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  		goto out_dispose_irq;
>  	}
>  
> +	device_init_wakeup(&pdev->dev, 1);
> +
>  	rtc->rtc_dev = rtc_device_register("mt6397-rtc", &pdev->dev,
>  					   &mtk_rtc_ops, THIS_MODULE);
>  	if (IS_ERR(rtc->rtc_dev)) {
> @@ -351,8 +353,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  		goto out_free_irq;
>  	}
>  
> -	device_init_wakeup(&pdev->dev, 1);
> -
>  	return 0;
>  
>  out_free_irq:

Thanks your correction.

Acked-by: Eddie Huang <eddie.huang@mediatek.com>

  reply	other threads:[~2015-07-02  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  8:36 [PATCH] rtc-mt6397: enable wakeup before registering rtc device Wei-Ning Huang
2015-07-02  8:49 ` Eddie Huang [this message]
2015-07-02 19:09 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435826955.21679.2.camel@mtksdaap41 \
    --to=eddie.huang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).