From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 06/17] VFIO: add vfio_external_{mask|is_active|set_automasked}
Date: Thu, 2 Jul 2015 15:17:16 +0200 [thread overview]
Message-ID: <1435843047-6327-7-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1435843047-6327-1-git-send-email-eric.auger@linaro.org>
Introduces 3 new external functions aimed at doing actions
on VFIO devices:
- mask VFIO IRQ
- get the active status of VFIO IRQ (active at interrupt
controller level or masked by the level-sensitive automasking).
- change the automasked property and switch the IRQ handler
(between automasked/ non automasked)
Their implementation is based on bus specific callbacks.
Note there is no way to discriminate between user-space
masking and automasked handler masking. As a consequence, is_active
will return true in case the IRQ was masked by the user-space.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v5 -> v6:
- implementation now uses external ops
- prototype changed (index, start, count) and returns int
V4: creation
---
drivers/vfio/vfio.c | 39 +++++++++++++++++++++++++++++++++++++++
include/linux/vfio.h | 16 ++++++++++++++++
2 files changed, 55 insertions(+)
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 2fb29df..af6901e 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -1527,6 +1527,45 @@ long vfio_external_check_extension(struct vfio_group *group, unsigned long arg)
}
EXPORT_SYMBOL_GPL(vfio_external_check_extension);
+int vfio_external_mask(struct vfio_device *vdev, unsigned index,
+ unsigned start, unsigned count)
+{
+ if (vdev->ops->external_ops &&
+ vdev->ops->external_ops->mask)
+ return vdev->ops->external_ops->mask(vdev->device_data,
+ index, start, count);
+ else
+ return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_mask);
+
+int vfio_external_is_active(struct vfio_device *vdev, unsigned index,
+ unsigned start, unsigned count)
+{
+ if (vdev->ops->external_ops &&
+ vdev->ops->external_ops->is_active)
+ return vdev->ops->external_ops->is_active(vdev->device_data,
+ index, start, count);
+ else
+ return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_is_active);
+
+int vfio_external_set_automasked(struct vfio_device *vdev,
+ unsigned index, unsigned start,
+ unsigned count, bool automasked)
+{
+ if (vdev->ops->external_ops &&
+ vdev->ops->external_ops->set_automasked)
+ return vdev->ops->external_ops->set_automasked(
+ vdev->device_data,
+ index, start,
+ count, automasked);
+ else
+ return -ENXIO;
+}
+EXPORT_SYMBOL_GPL(vfio_external_set_automasked);
+
/**
* Module/class support
*/
diff --git a/include/linux/vfio.h b/include/linux/vfio.h
index d79e8a9..31d3c95 100644
--- a/include/linux/vfio.h
+++ b/include/linux/vfio.h
@@ -107,6 +107,22 @@ extern int vfio_external_user_iommu_id(struct vfio_group *group);
extern long vfio_external_check_extension(struct vfio_group *group,
unsigned long arg);
+extern int vfio_external_mask(struct vfio_device *vdev, unsigned index,
+ unsigned start, unsigned count);
+/*
+ * returns whether the VFIO IRQ is active:
+ * true if not yet deactivated at interrupt controller level or if
+ * automasked (level sensitive IRQ). Unfortunately there is no way to
+ * discriminate between handler auto-masking and user-space masking
+ */
+extern int vfio_external_is_active(struct vfio_device *vdev,
+ unsigned index, unsigned start,
+ unsigned count);
+
+extern int vfio_external_set_automasked(struct vfio_device *vdev,
+ unsigned index, unsigned start,
+ unsigned count, bool automasked);
+
struct pci_dev;
#ifdef CONFIG_EEH
extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev);
--
1.9.1
next prev parent reply other threads:[~2015-07-02 13:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:17 [RFC 00/17] ARM IRQ forward control based on IRQ bypass manager Eric Auger
2015-07-02 13:17 ` [RFC 01/17] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-07-02 13:17 ` [RFC 02/17] VFIO: platform: single handler using function pointer Eric Auger
2015-07-02 13:17 ` [RFC 03/17] VFIO: Introduce vfio_device_external_ops Eric Auger
2015-07-02 13:17 ` [RFC 04/17] VFIO: pci: initialize vfio_device_external_ops Eric Auger
2015-07-02 13:17 ` [RFC 05/17] VFIO: platform: implement vfio_device_external_ops callbacks Eric Auger
2015-07-02 13:17 ` Eric Auger [this message]
2015-07-02 13:17 ` [RFC 07/17] KVM: arm: rename pause into power_off Eric Auger
2015-07-02 13:17 ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt,resume]_guest Eric Auger
2015-07-03 11:55 ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt, resume]_guest Eric Auger
2015-07-03 12:14 ` Marc Zyngier
2015-07-02 13:17 ` [RFC 09/17] bypass: IRQ bypass manager proto by Alex Eric Auger
2015-07-03 2:16 ` Wu, Feng
2015-07-03 5:32 ` Eric Auger
2015-07-02 13:17 ` [RFC 10/17] KVM: arm: select IRQ_BYPASS_MANAGER Eric Auger
2015-07-02 13:17 ` [RFC 11/17] VFIO: platform: " Eric Auger
2015-07-02 13:17 ` [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control Eric Auger
2015-07-02 13:40 ` Paolo Bonzini
2015-07-03 2:19 ` Wu, Feng
2015-07-03 2:24 ` Wu, Feng
2015-07-03 6:54 ` Eric Auger
2015-07-03 7:02 ` Paolo Bonzini
2015-07-03 13:12 ` Eric Auger
2015-07-03 17:20 ` Paolo Bonzini
2015-07-03 17:23 ` Eric Auger
2015-07-03 2:43 ` Wu, Feng
2015-07-03 6:52 ` Paolo Bonzini
2015-07-03 7:00 ` Wu, Feng
2015-07-03 7:06 ` Paolo Bonzini
2015-07-03 7:16 ` Wu, Feng
2015-07-03 7:08 ` Paolo Bonzini
2015-07-02 13:17 ` [RFC 13/17] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-07-02 13:41 ` Paolo Bonzini
2015-07-02 13:17 ` [RFC 14/17] KVM: arm/arm64: vgic: forwarding control Eric Auger
2015-07-02 13:17 ` [RFC 15/17] KVM: arm/arm64: implement IRQ bypass consumer functions Eric Auger
2015-07-02 13:17 ` [RFC 16/17] KVM: eventfd: add irq bypass consumer management Eric Auger
2015-07-02 13:42 ` Paolo Bonzini
2015-07-02 13:53 ` Eric Auger
2015-07-06 7:55 ` Wu, Feng
2015-07-06 11:19 ` Eric Auger
2015-07-06 12:17 ` Wu, Feng
2015-07-02 13:17 ` [RFC 17/17] VFIO: platform: add irq bypass producer management Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435843047-6327-7-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).