From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] clk: rockchip: fix issues in the mmc-phase clock
Date: Sun, 5 Jul 2015 11:00:15 +0200 [thread overview]
Message-ID: <1436086820-3757-3-git-send-email-heiko@sntech.de> (raw)
In-Reply-To: <1436086820-3757-1-git-send-email-heiko@sntech.de>
The review for the new inverter clock type uncovered some issues (missing
headers and name handling) that are also present in the mmc-phase clock
type, I got (to much) inspiration from. Fix these there too.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/clk/rockchip/clk-mmc-phase.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/rockchip/clk-mmc-phase.c b/drivers/clk/rockchip/clk-mmc-phase.c
index e9f8df32..f2c6889 100644
--- a/drivers/clk/rockchip/clk-mmc-phase.c
+++ b/drivers/clk/rockchip/clk-mmc-phase.c
@@ -15,6 +15,8 @@
#include <linux/slab.h>
#include <linux/clk-provider.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
#include "clk.h"
struct rockchip_mmc_clock {
@@ -131,6 +133,7 @@ struct clk *rockchip_clk_register_mmc(const char *name,
if (!mmc_clock)
return NULL;
+ init.name = name;
init.num_parents = num_parents;
init.parent_names = parent_names;
init.ops = &rockchip_mmc_clk_ops;
@@ -139,9 +142,6 @@ struct clk *rockchip_clk_register_mmc(const char *name,
mmc_clock->reg = reg;
mmc_clock->shift = shift;
- if (name)
- init.name = name;
-
clk = clk_register(NULL, &mmc_clock->hw);
if (IS_ERR(clk))
goto err_free;
--
2.1.4
next prev parent reply other threads:[~2015-07-05 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 9:00 [PATCH v3 0/7] clk: rockchip: add support for the clock-tree of the rk3368 Heiko Stuebner
2015-07-05 9:00 ` [PATCH 1/7] clk: rockchip: add support for phase inverters Heiko Stuebner
2015-07-06 22:00 ` Stephen Boyd
2015-07-06 22:06 ` Stephen Boyd
2015-07-05 9:00 ` Heiko Stuebner [this message]
2015-07-06 22:07 ` [PATCH 2/7] clk: rockchip: fix issues in the mmc-phase clock Stephen Boyd
2015-07-05 9:00 ` [PATCH 3/7] clk: rockchip: define the inverters of rk3066/rk3188 and rk3288 Heiko Stuebner
2015-07-06 22:08 ` Stephen Boyd
2015-07-05 9:00 ` [PATCH 4/7] dt-bindings: add documentation of rk3668 clock controller Heiko Stuebner
2015-07-06 22:10 ` Stephen Boyd
2015-07-05 9:00 ` [PATCH 5/7] clk: rockchip: add dt-binding header for rk3368 Heiko Stuebner
2015-07-06 22:11 ` Stephen Boyd
2015-07-05 9:00 ` [PATCH 6/7] clk: rockchip: add missing include guards Heiko Stuebner
2015-07-06 22:12 ` Stephen Boyd
2015-07-06 22:12 ` Stephen Boyd
2015-07-05 9:00 ` [PATCH 7/7] clk: rockchip: add rk3368 clock controller Heiko Stuebner
2015-07-06 22:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436086820-3757-3-git-send-email-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).