From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control
Date: Mon, 6 Jul 2015 14:11:29 +0200 [thread overview]
Message-ID: <1436184692-20927-4-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1436184692-20927-1-git-send-email-eric.auger@linaro.org>
- [add,del]_[consumer,producer] updated to takes both the consumer and
producer handles. This is requested to combine info from both,
typically to link the source irq owned by the producer with the gsi
owned by the consumer (forwarded IRQ setup).
- new methods are added:
x stop/resume: Those are needed for forwarding since the state change
requires to entermingle actions at consumer, producer.
x consumer update for posted interrupts
- On handshake, we now call connect, disconnect which features the more
complex sequence.
- add irq on producer side
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v1 -> v2:
- remove vfio_device, kvm, gsi, opaque fields included in v1 except common
- all those in can be retrieved with container_of in callbacks
---
include/linux/irqbypass.h | 19 ++++++++++++++++---
kernel/irq/bypass.c | 44 ++++++++++++++++++++++++++++++++++++++++----
2 files changed, 56 insertions(+), 7 deletions(-)
diff --git a/include/linux/irqbypass.h b/include/linux/irqbypass.h
index 718508e..8f62235 100644
--- a/include/linux/irqbypass.h
+++ b/include/linux/irqbypass.h
@@ -3,17 +3,30 @@
#include <linux/list.h>
+struct irq_bypass_consumer;
+
struct irq_bypass_producer {
struct list_head node;
void *token;
- /* TBD */
+ int irq; /* linux irq */
+ void (*stop)(struct irq_bypass_producer *);
+ void (*resume)(struct irq_bypass_producer *);
+ void (*add_consumer)(struct irq_bypass_producer *,
+ struct irq_bypass_consumer *);
+ void (*del_consumer)(struct irq_bypass_producer *,
+ struct irq_bypass_consumer *);
};
struct irq_bypass_consumer {
struct list_head node;
void *token;
- void (*add_producer)(struct irq_bypass_producer *);
- void (*del_producer)(struct irq_bypass_producer *);
+ void (*stop)(struct irq_bypass_consumer *);
+ void (*resume)(struct irq_bypass_consumer *);
+ void (*add_producer)(struct irq_bypass_consumer *,
+ struct irq_bypass_producer *);
+ void (*del_producer)(struct irq_bypass_consumer *,
+ struct irq_bypass_producer *);
+ void (*update)(struct irq_bypass_consumer *);
};
int irq_bypass_register_producer(struct irq_bypass_producer *);
diff --git a/kernel/irq/bypass.c b/kernel/irq/bypass.c
index 5d0f92b..efadbe5 100644
--- a/kernel/irq/bypass.c
+++ b/kernel/irq/bypass.c
@@ -19,6 +19,42 @@ static LIST_HEAD(producers);
static LIST_HEAD(consumers);
static DEFINE_MUTEX(lock);
+/* lock must be hold when calling connect */
+static void connect(struct irq_bypass_producer *prod,
+ struct irq_bypass_consumer *cons)
+{
+ if (prod->stop)
+ prod->stop(prod);
+ if (cons->stop)
+ cons->stop(cons);
+ if (prod->add_consumer)
+ prod->add_consumer(prod, cons);
+ if (cons->add_producer)
+ cons->add_producer(cons, prod);
+ if (cons->resume)
+ cons->resume(cons);
+ if (prod->resume)
+ prod->resume(prod);
+}
+
+/* lock must be hold when calling disconnect */
+static void disconnect(struct irq_bypass_producer *prod,
+ struct irq_bypass_consumer *cons)
+{
+ if (prod->stop)
+ prod->stop(prod);
+ if (cons->stop)
+ cons->stop(cons);
+ if (cons->del_producer)
+ cons->del_producer(cons, prod);
+ if (prod->del_consumer)
+ prod->del_consumer(prod, cons);
+ if (cons->resume)
+ cons->resume(cons);
+ if (prod->resume)
+ prod->resume(prod);
+}
+
int irq_bypass_register_producer(struct irq_bypass_producer *producer)
{
struct irq_bypass_producer *tmp;
@@ -38,7 +74,7 @@ int irq_bypass_register_producer(struct irq_bypass_producer *producer)
list_for_each_entry(consumer, &consumers, node) {
if (consumer->token == producer->token) {
- consumer->add_producer(producer);
+ connect(producer, consumer);
break;
}
}
@@ -56,7 +92,7 @@ void irq_bypass_unregister_producer(struct irq_bypass_producer *producer)
list_for_each_entry(consumer, &consumers, node) {
if (consumer->token == producer->token) {
- consumer->del_producer(producer);
+ disconnect(producer, consumer);
break;
}
}
@@ -86,7 +122,7 @@ int irq_bypass_register_consumer(struct irq_bypass_consumer *consumer)
list_for_each_entry(producer, &producers, node) {
if (producer->token == consumer->token) {
- consumer->add_producer(producer);
+ connect(producer, consumer);
break;
}
}
@@ -104,7 +140,7 @@ void irq_bypass_unregister_consumer(struct irq_bypass_consumer *consumer)
list_for_each_entry(producer, &producers, node) {
if (producer->token == consumer->token) {
- consumer->del_producer(producer);
+ disconnect(producer, consumer);
break;
}
}
--
1.9.1
next prev parent reply other threads:[~2015-07-06 12:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 12:11 [RFC v2 0/6] IRQ bypass manager and irqfd consumer Eric Auger
2015-07-06 12:11 ` [RFC v2 1/6] KVM: arm/arm64: select IRQ_BYPASS_MANAGER Eric Auger
2015-07-06 12:24 ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 2/6] VFIO: platform: " Eric Auger
2015-07-06 12:11 ` Eric Auger [this message]
2015-07-06 12:27 ` [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control Paolo Bonzini
2015-07-06 15:35 ` Eric Auger
2015-07-06 15:57 ` Paolo Bonzini
2015-07-06 17:09 ` Eric Auger
2015-07-06 17:41 ` Paolo Bonzini
2015-07-07 7:10 ` Eric Auger
2015-07-07 8:58 ` Paolo Bonzini
2015-07-07 10:58 ` Wu, Feng
2015-07-07 11:00 ` Paolo Bonzini
2015-07-07 11:13 ` Wu, Feng
2015-07-07 11:13 ` Paolo Bonzini
2015-07-07 11:18 ` Wu, Feng
2015-07-07 11:21 ` Paolo Bonzini
2015-07-07 11:24 ` Wu, Feng
2015-07-07 11:33 ` Wu, Feng
2015-07-07 13:22 ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 4/6] KVM: create kvm_irqfd.h Eric Auger
2015-07-06 12:11 ` [RFC v2 5/6] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-07-06 12:11 ` [RFC v2 6/6] KVM: eventfd: add irq bypass consumer management Eric Auger
2015-07-07 8:47 ` Wu, Feng
2015-07-07 9:05 ` Eric Auger
2015-07-07 9:13 ` Wu, Feng
2015-07-07 17:17 ` [RFC v2 0/6] IRQ bypass manager and irqfd consumer Alex Williamson
2015-07-09 12:28 ` Joerg Roedel
2015-07-09 14:13 ` Alex Williamson
2015-07-09 14:38 ` Paolo Bonzini
2015-07-09 15:34 ` Joerg Roedel
2015-07-09 16:06 ` Alex Williamson
2015-07-24 1:27 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436184692-20927-4-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).