linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2 6/6] KVM: eventfd: add irq bypass consumer management
Date: Mon,  6 Jul 2015 14:11:32 +0200	[thread overview]
Message-ID: <1436184692-20927-7-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1436184692-20927-1-git-send-email-eric.auger@linaro.org>

This patch adds the registration/unregistration of an
irq_bypass_consumer on irqfd assignment/deassignment.

Signed-off-by: Eric Auger <eric.auger@linaro.org>

---

v1 -> v2:
- populate of kvm and gsi removed
- unregister the consumer on irqfd_shutdown
---
 include/linux/kvm_irqfd.h |  1 +
 virt/kvm/eventfd.c        | 14 +++++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/include/linux/kvm_irqfd.h b/include/linux/kvm_irqfd.h
index f926b39..3c0bd07 100644
--- a/include/linux/kvm_irqfd.h
+++ b/include/linux/kvm_irqfd.h
@@ -64,6 +64,7 @@ struct kvm_kernel_irqfd {
 	struct list_head list;
 	poll_table pt;
 	struct work_struct shutdown;
+	struct irq_bypass_consumer consumer;
 };
 
 #endif /* __LINUX_KVM_IRQFD_H */
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index b79dc61..9452754 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -35,6 +35,7 @@
 #include <linux/srcu.h>
 #include <linux/slab.h>
 #include <linux/seqlock.h>
+#include <linux/irqbypass.h>
 #include <trace/events/kvm.h>
 
 #include <kvm/iodev.h>
@@ -140,6 +141,7 @@ irqfd_shutdown(struct work_struct *work)
 	/*
 	 * It is now safe to release the object's resources
 	 */
+	irq_bypass_unregister_consumer(&irqfd->consumer);
 	eventfd_ctx_put(irqfd->eventfd);
 	kfree(irqfd);
 }
@@ -380,7 +382,14 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
 	 */
 	fdput(f);
 
-	/* irq_bypass_register_consumer(); */
+	irqfd->consumer.token = (void *)irqfd->eventfd;
+	irqfd->consumer.add_producer = kvm_arch_irq_bypass_add_producer;
+	irqfd->consumer.del_producer = kvm_arch_irq_bypass_del_producer;
+	irqfd->consumer.stop = kvm_arch_irq_bypass_stop;
+	irqfd->consumer.resume = kvm_arch_irq_bypass_resume;
+	irqfd->consumer.update = kvm_arch_irq_bypass_update;
+	ret = irq_bypass_register_consumer(&irqfd->consumer);
+	WARN_ON(ret);
 
 	return 0;
 
@@ -481,8 +490,6 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args)
 	struct kvm_kernel_irqfd *irqfd, *tmp;
 	struct eventfd_ctx *eventfd;
 
-	/* irq_bypass_unregister_consumer() */
-
 	eventfd = eventfd_ctx_fdget(args->fd);
 	if (IS_ERR(eventfd))
 		return PTR_ERR(eventfd);
@@ -501,6 +508,7 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args)
 			irqfd->irq_entry.type = 0;
 			write_seqcount_end(&irqfd->irq_entry_sc);
 			irqfd_deactivate(irqfd);
+			irq_bypass_unregister_consumer(&irqfd->consumer);
 		}
 	}
 
-- 
1.9.1

  parent reply	other threads:[~2015-07-06 12:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 12:11 [RFC v2 0/6] IRQ bypass manager and irqfd consumer Eric Auger
2015-07-06 12:11 ` [RFC v2 1/6] KVM: arm/arm64: select IRQ_BYPASS_MANAGER Eric Auger
2015-07-06 12:24   ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 2/6] VFIO: platform: " Eric Auger
2015-07-06 12:11 ` [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control Eric Auger
2015-07-06 12:27   ` Paolo Bonzini
2015-07-06 15:35     ` Eric Auger
2015-07-06 15:57       ` Paolo Bonzini
2015-07-06 17:09         ` Eric Auger
2015-07-06 17:41           ` Paolo Bonzini
2015-07-07  7:10             ` Eric Auger
2015-07-07  8:58               ` Paolo Bonzini
2015-07-07 10:58   ` Wu, Feng
2015-07-07 11:00     ` Paolo Bonzini
2015-07-07 11:13       ` Wu, Feng
2015-07-07 11:13         ` Paolo Bonzini
2015-07-07 11:18           ` Wu, Feng
2015-07-07 11:21             ` Paolo Bonzini
2015-07-07 11:24               ` Wu, Feng
2015-07-07 11:33                 ` Wu, Feng
2015-07-07 13:22                   ` Paolo Bonzini
2015-07-06 12:11 ` [RFC v2 4/6] KVM: create kvm_irqfd.h Eric Auger
2015-07-06 12:11 ` [RFC v2 5/6] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-07-06 12:11 ` Eric Auger [this message]
2015-07-07  8:47   ` [RFC v2 6/6] KVM: eventfd: add irq bypass consumer management Wu, Feng
2015-07-07  9:05     ` Eric Auger
2015-07-07  9:13       ` Wu, Feng
2015-07-07 17:17 ` [RFC v2 0/6] IRQ bypass manager and irqfd consumer Alex Williamson
2015-07-09 12:28   ` Joerg Roedel
2015-07-09 14:13     ` Alex Williamson
2015-07-09 14:38       ` Paolo Bonzini
2015-07-09 15:34         ` Joerg Roedel
2015-07-09 16:06           ` Alex Williamson
2015-07-24  1:27 ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436184692-20927-7-git-send-email-eric.auger@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).