linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamesjj.liao@mediatek.com (James Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers
Date: Tue, 7 Jul 2015 14:56:46 +0800	[thread overview]
Message-ID: <1436252206.3526.80.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omAo-d_bK=2HDu98xHvqhnVgJUBy4jbYVGKqsfWRX-EfDA@mail.gmail.com>

Hi Daniel,

On Fri, 2015-07-03 at 18:46 +0800, Daniel Kurtz wrote:
> On Fri, Jul 3, 2015 at 7:40 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > DT nodes typically have a reg property. Not having a reg property is a
> > good indicator of a problem with the binding. A syscon is used when you
> > have a DT node with a reg property and some driver attached to it, but
> > you need to poke some bits in another register region that isn't part of
> > the reg property. Instead of having multiple nodes with two reg
> > properties where the second one is the same, we use a phandle and a syscon.
> >
> > If clock-controller isn't acceptable maybe clock-reset-contoller would
> > work? Or "power-controller"? We certainly shouldn't be making up
> > multiple nodes for one hardware block. Of course, the subject of the
> > patch is "bindings for clock controllers", so it may be that the
> > registers are predominantly clock related and so the name is appropriate
> > already.
> 
> Using "clock-controller" seems to fit best with the bindings
> introduced by this patch.
> 
> However, if these bindings are for hardware blocks that contain a grab
> bag of various functionality that will be added in later patches, then
> I think "syscon" might be best.

I referred some dt-binding documents that contain clock and reset
controller in the same unit:

qcom,gcc.txt:

	clock-controller at 900000 {
		compatible = "qcom,gcc-msm8960";

nvidia,tegra124-car.txt:

	tegra_car: clock {
		compatible = "nvidia,tegra124-car";

rockchip,rk3188-cru.txt:

	cru: cru at 20000000 {
		compatible = "rockchip,rk3188-cru";

Rockchip use "Clock and Reset Unit" as their controller's name. The
other two use "clock" or "clock-controller" as their controller's name.

It looks like "clock-controller" is also an acceptable name for
clock/reset controllers. So I would like to keep this name in next
patch.


Best regards,

James

  reply	other threads:[~2015-07-07  6:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  2:58 [PATCH v2 0/4] Add Mediatek MT8173 subsystem clocks support James Liao
2015-06-30  2:58 ` [PATCH v2 1/4] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-01 14:21   ` Daniel Kurtz
2015-07-02  2:07     ` Daniel Kurtz
2015-07-02  2:18     ` James Liao
2015-07-02 23:03   ` Stephen Boyd
2015-07-03  6:29     ` Daniel Kurtz
2015-07-06 22:52       ` Stephen Boyd
2015-06-30  2:58 ` [PATCH v2 2/4] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-01 13:47   ` Daniel Kurtz
2015-07-02  2:52     ` James Liao
2015-07-02  4:26       ` Daniel Kurtz
2015-07-02 23:40         ` Stephen Boyd
2015-07-03 10:46           ` Daniel Kurtz
2015-07-07  6:56             ` James Liao [this message]
2015-07-01 16:03   ` Rob Herring
2015-06-30  2:58 ` [PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-01 14:54   ` Daniel Kurtz
2015-07-03  5:15     ` James Liao
2015-07-03  6:08       ` Daniel Kurtz
2015-06-30  2:58 ` [PATCH v2 4/4] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
     [not found]   ` <CAGS+omBRAJVN3uPYn9YdKZ3VBj61c-rpY_cNgnK6x9U0uJBPYw@mail.gmail.com>
2015-07-01 15:22     ` Daniel Kurtz
2015-07-03  5:38       ` James Liao
2015-07-03  6:28         ` Daniel Kurtz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436252206.3526.80.camel@mtksdaap41 \
    --to=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).