From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v6 4/6] mfd: 88pm800: Remove unnecessary protection around pdata
Date: Wed, 8 Jul 2015 17:56:30 +0530 [thread overview]
Message-ID: <1436358392-15449-5-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1436358392-15449-1-git-send-email-vaibhav.hiremath@linaro.org>
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/88pm800.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index af8232f..074ba8b 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -302,7 +302,7 @@ static int device_gpadc_init(struct pm80x_chip *chip)
mask = (PM800_GPADC_GP_BIAS_EN0 | PM800_GPADC_GP_BIAS_EN1 |
PM800_GPADC_GP_BIAS_EN2 | PM800_GPADC_GP_BIAS_EN3);
- if (pdata && (pdata->batt_det == 0))
+ if (pdata->batt_det == 0)
data = (PM800_GPADC_GP_BIAS_EN0 | PM800_GPADC_GP_BIAS_EN1 |
PM800_GPADC_GP_BIAS_EN2 | PM800_GPADC_GP_BIAS_EN3);
else
@@ -331,11 +331,8 @@ static int device_rtc_init(struct pm80x_chip *chip)
{
struct pm80x_platform_data *pdata = dev_get_platdata(chip->dev);
- if (pdata) {
- rtc_devs[0].platform_data = pdata->rtc;
- rtc_devs[0].pdata_size =
- pdata->rtc ? sizeof(struct pm80x_rtc_pdata) : 0;
- }
+ rtc_devs[0].platform_data = pdata->rtc;
+ rtc_devs[0].pdata_size = pdata->rtc ? sizeof(struct pm80x_rtc_pdata) : 0;
return mfd_add_devices(chip->dev, 0, &rtc_devs[0],
ARRAY_SIZE(rtc_devs), NULL, 0, NULL);
@@ -478,7 +475,7 @@ static int device_800_init(struct pm80x_chip *chip)
goto out;
}
if (val & PM800_ALARM_WAKEUP) {
- if (pdata && pdata->rtc)
+ if (pdata->rtc)
pdata->rtc->rtc_wakeup = 1;
}
@@ -580,7 +577,7 @@ static int pm800_probe(struct i2c_client *client,
goto err_device_init;
}
- if (pdata && pdata->plat_config)
+ if (pdata->plat_config)
pdata->plat_config(chip, pdata);
return 0;
--
1.9.1
next prev parent reply other threads:[~2015-07-08 12:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 12:26 [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-07-08 12:26 ` [PATCH-v6 1/6] mfd: 88pm800: remove duplicate dev_err calls during probe Vaibhav Hiremath
2015-08-24 13:54 ` Lee Jones
2015-07-08 12:26 ` [PATCH-v6 2/6] mfd: 88pm800: Add device tree support Vaibhav Hiremath
2015-07-08 12:26 ` [PATCH-v6 3/6] mfd: 88pm800: Get pdata from 'device' rather than passing as a parameter Vaibhav Hiremath
2015-08-24 13:54 ` Lee Jones
2015-07-08 12:26 ` Vaibhav Hiremath [this message]
2015-07-08 12:26 ` [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath
2015-08-24 13:54 ` Lee Jones
2015-08-24 15:20 ` Vaibhav Hiremath
2015-08-24 15:51 ` Lee Jones
2015-08-24 16:47 ` Vaibhav Hiremath
2015-08-25 8:30 ` Lee Jones
2015-08-25 9:02 ` Vaibhav Hiremath
2015-08-25 9:30 ` Lee Jones
2015-07-08 12:26 ` [PATCH-v6 6/6] mfd: devicetree: bindings: Add new 88pm800 mfd binding Vaibhav Hiremath
2015-07-13 18:57 ` [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-08-24 6:43 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436358392-15449-5-git-send-email-vaibhav.hiremath@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).