From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value
Date: Thu, 9 Jul 2015 18:11:31 +0530 [thread overview]
Message-ID: <1436445692-10656-3-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1436445692-10656-1-git-send-email-vaibhav.hiremath@linaro.org>
From: Yi Zhang <yizhang@marvell.com>
As per datasheet,
Except LDO2, all other LDO's use bit [3:0] for VOUT select.
Current code uses wrong mask value of 0x1f, So this patch
fixes it to use 0xf.
Signed-off-by: Yi Zhang <yizhang@marvell.com>
[vaibhav.hiremath at linaro.org: Updated changelog with more detailed description]
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
drivers/regulator/88pm800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
index d22a098..fdebd23 100644
--- a/drivers/regulator/88pm800.c
+++ b/drivers/regulator/88pm800.c
@@ -137,7 +137,7 @@ struct pm800_regulators {
.owner = THIS_MODULE, \
.n_voltages = ARRAY_SIZE(ldo_volt_table), \
.vsel_reg = PM800_##vreg##_VOUT, \
- .vsel_mask = 0x1f, \
+ .vsel_mask = 0xf, \
.enable_reg = PM800_##ereg, \
.enable_mask = 1 << (ebit), \
.volt_table = ldo_volt_table, \
--
1.9.1
next prev parent reply other threads:[~2015-07-09 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 12:41 [PATCH 0/3] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath
2015-07-09 12:41 ` [PATCH 1/3] " Vaibhav Hiremath
2015-07-09 13:59 ` Lee Jones
2015-07-09 18:35 ` Mark Brown
2015-07-09 12:41 ` Vaibhav Hiremath [this message]
2015-07-09 19:04 ` [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value Mark Brown
2015-07-10 12:07 ` Vaibhav Hiremath
2015-07-09 12:41 ` [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status Vaibhav Hiremath
2015-07-09 19:05 ` Mark Brown
2015-07-10 12:11 ` Vaibhav Hiremath
2015-07-09 19:36 ` Valdis.Kletnieks at vt.edu
2015-07-09 22:05 ` Mark Brown
2015-07-10 12:12 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436445692-10656-3-git-send-email-vaibhav.hiremath@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).