From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] irqchip: GICv3: Skip LPI deactivation
Date: Thu, 9 Jul 2015 14:19:08 +0100 [thread overview]
Message-ID: <1436447951-22357-4-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1436447951-22357-1-git-send-email-marc.zyngier@arm.com>
Contrary to other GICv3 interrupts, LPIs do not have an active state
by virtue of being edge-triggered only (they only have a pending state).
Given this, there is no point trying to deactivate them, and we can
skip the ICC_DIR_EL1 entierely.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
drivers/irqchip/irq-gic-v3.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 49768fc..e02592b 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -295,10 +295,14 @@ static int gic_irq_get_irqchip_state(struct irq_data *d,
static void gic_eoi_irq(struct irq_data *d)
{
- if (static_key_true(&supports_deactivate))
+ if (static_key_true(&supports_deactivate)) {
+ /* No need to deactivate an LPI */
+ if (gic_irq(d) >= 8192)
+ return;
gic_write_dir(gic_irq(d));
- else
+ } else {
gic_write_eoir(gic_irq(d));
+ }
}
static int gic_set_type(struct irq_data *d, unsigned int type)
--
2.1.4
next prev parent reply other threads:[~2015-07-09 13:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 13:19 [PATCH 0/6] irqchip: GICv2/v3: Add support for irq_vcpu_affinity Marc Zyngier
2015-07-09 13:19 ` [PATCH 1/6] irqchip: GICv3: Convert to EOImode == 1 Marc Zyngier
2015-08-11 9:14 ` Eric Auger
2015-08-12 12:38 ` Marc Zyngier
2015-07-09 13:19 ` [PATCH 2/6] irqchip: GIC: " Marc Zyngier
2015-08-11 9:15 ` Eric Auger
2015-08-12 13:31 ` Marc Zyngier
2015-08-12 17:40 ` Catalin Marinas
2015-07-09 13:19 ` Marc Zyngier [this message]
2015-08-11 9:42 ` [PATCH 3/6] irqchip: GICv3: Skip LPI deactivation Eric Auger
2015-08-12 13:34 ` Marc Zyngier
2015-08-12 14:28 ` Eric Auger
2015-07-09 13:19 ` [PATCH 4/6] irqchip: GIC: Use chip_data instead of handler_data for cascaded interrupts Marc Zyngier
2015-07-09 21:33 ` Thomas Gleixner
2015-07-10 7:52 ` Marc Zyngier
2015-07-10 8:17 ` Jiang Liu
2015-07-10 8:21 ` Marc Zyngier
2015-08-11 9:45 ` Eric Auger
2015-08-12 13:41 ` Marc Zyngier
2015-07-09 13:19 ` [PATCH 5/6] irqchip: GICv3: Don't deactivate interrupts forwarded to a guest Marc Zyngier
2015-08-11 10:03 ` Eric Auger
2015-08-12 14:20 ` Marc Zyngier
2015-08-12 15:09 ` Eric Auger
2015-08-12 15:40 ` Marc Zyngier
2015-08-12 15:51 ` Eric Auger
2015-07-09 13:19 ` [PATCH 6/6] irqchip: GIC: " Marc Zyngier
2015-08-11 10:06 ` [PATCH 0/6] irqchip: GICv2/v3: Add support for irq_vcpu_affinity Eric Auger
2015-08-12 14:21 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436447951-22357-4-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).