From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name
Date: Fri, 17 Jul 2015 11:32:47 +0200 [thread overview]
Message-ID: <1437125570-28623-7-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1437125570-28623-1-git-send-email-mpa@pengutronix.de>
The DT describes gpios with subnodes. These subnodes can contain a
property 'line-name'. This information can be useful in other areas
where we want to identify a GPIO by its name.
This patch stores the line-name in the gpio descriptor.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/gpio/gpiolib-of.c | 29 ++++++++++++++++++++---------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 64950591a764..cefc665a558c 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -184,11 +184,6 @@ static struct gpio_desc *of_parse_gpio(struct device_node *np,
*dflags |= GPIOD_OUT_LOW;
else if (of_property_read_bool(np, "output-high"))
*dflags |= GPIOD_OUT_HIGH;
- else {
- pr_warn("GPIO line %d (%s): no hogging state specified, bailing out\n",
- desc_to_gpio(gg_data.out_gpio), np->name);
- return ERR_PTR(-EINVAL);
- }
if (name && of_property_read_string(np, "line-name", name))
*name = np->name;
@@ -214,15 +209,31 @@ static void of_gpiochip_scan_gpios(struct gpio_chip *chip)
for_each_child_of_node(chip->of_node, np) {
const char *name = NULL;
- if (!of_property_read_bool(np, "gpio-hog"))
- continue;
+ struct gpio_desc *name_desc;
desc = of_parse_gpio(np, &name, &lflags, &dflags);
if (IS_ERR(desc))
continue;
- if (gpiod_hog(desc, name, lflags, dflags))
- continue;
+ if (name) {
+ name_desc = gpio_name_to_desc(name);
+ if (name_desc)
+ pr_err("GPIO name collision for '%s' detected at GPIO line %d (%s)\n",
+ name, desc_to_gpio(desc), np->name);
+ else
+ desc->name = name;
+ }
+
+ if (of_property_read_bool(np, "gpio-hog")) {
+ if (!dflags) {
+ pr_warn("GPIO line %d (%s): no hogging state specified, bailing out\n",
+ desc_to_gpio(desc), np->name);
+ continue;
+ }
+
+ if (gpiod_hog(desc, name, lflags, dflags))
+ continue;
+ }
}
}
--
2.1.4
next prev parent reply other threads:[~2015-07-17 9:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 9:32 [PATCH 0/9] gpiolib: Add GPIO name support Markus Pargmann
2015-07-17 9:32 ` [PATCH 1/9] gpiolib: Fix possible use of wrong name Markus Pargmann
2015-07-28 9:03 ` Johan Hovold
2015-07-29 6:46 ` Markus Pargmann
2015-07-17 9:32 ` [PATCH 2/9] gpiolib-of: Rename gpio_hog functions to be generic Markus Pargmann
2015-07-17 9:32 ` [PATCH 3/9] gpio: Allow hogged gpios to be requested Markus Pargmann
2015-07-17 20:27 ` Uwe Kleine-König
2015-07-19 14:01 ` Markus Pargmann
2015-07-20 6:32 ` Uwe Kleine-König
2015-07-20 7:51 ` Markus Pargmann
2015-07-28 9:17 ` Johan Hovold
2015-07-29 6:52 ` Markus Pargmann
2015-08-10 9:20 ` Linus Walleij
2015-07-17 9:32 ` [PATCH 4/9] gpio: Add 'name' to the gpio descriptor struct Markus Pargmann
2015-07-28 9:24 ` Johan Hovold
2015-07-17 9:32 ` [PATCH 5/9] gpiolib: Implement gpio_name_to_desc() Markus Pargmann
2015-07-17 9:32 ` Markus Pargmann [this message]
2015-07-28 9:31 ` [PATCH 6/9] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name Johan Hovold
2015-07-29 6:52 ` Markus Pargmann
2015-07-17 9:32 ` [PATCH 7/9] gpiolib-sysfs: Add gpio name parsing for sysfs export Markus Pargmann
2015-07-28 9:50 ` Johan Hovold
2015-07-29 6:57 ` Markus Pargmann
2015-07-31 8:44 ` Johan Hovold
2015-07-17 9:32 ` [PATCH 8/9] gpiolib-sysfs: Show gpio-name in /sys/class/gpio/gpio*/name Markus Pargmann
2015-07-28 9:53 ` Johan Hovold
2015-07-29 7:02 ` Markus Pargmann
2015-07-17 9:32 ` [PATCH 9/9] gpiolib: Add gpio name information to /sys/kernel/debug/gpio Markus Pargmann
2015-07-28 9:58 ` Johan Hovold
2015-07-29 7:08 ` Markus Pargmann
2015-07-31 8:54 ` Johan Hovold
2015-07-31 10:41 ` Markus Pargmann
2015-07-31 10:45 ` Johan Hovold
2015-07-31 10:49 ` Lucas Stach
2015-07-17 20:05 ` [PATCH 0/9] gpiolib: Add GPIO name support Linus Walleij
2015-07-21 9:00 ` Alexandre Courbot
2015-07-21 9:54 ` Uwe Kleine-König
2015-07-21 10:10 ` Markus Pargmann
[not found] ` <CAGmoSHt0Kg-cxe3U6uV40=ttmFbDruRcJZNxtmSZ=gmZQN5fTw@mail.gmail.com>
2015-07-31 9:49 ` Johan Hovold
2015-07-31 10:42 ` Markus Pargmann
2015-07-28 14:16 ` Johan Hovold
2015-07-29 9:23 ` Linus Walleij
2015-07-31 9:40 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437125570-28623-7-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).