From: HenryC.Chen@mediatek.com (Henry Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] regulator: mt6311: Add support for mt6311 regulator
Date: Wed, 22 Jul 2015 22:42:54 +0800 [thread overview]
Message-ID: <1437576174.30329.84.camel@mtksdaap41> (raw)
In-Reply-To: <CABxcv=ncxfeqo1vfz6XzJWYUOGeFGAbDmz2M_PzM+8PBQvXjgw@mail.gmail.com>
On Wed, 2015-07-22 at 14:50 +0200, Javier Martinez Canillas wrote:
> > +
> > +struct mt6311 {
> > + struct device *dev;
> > + struct regmap *regmap;
> > + struct regulator_dev *rdev[MT6311_MAX_REGULATORS];
> > + int num_regulator;
> > + int chip_cid;
> > +};
>
> It seems this struct can be removed, the rdev, num_regulator and
> chip_cid fields are set but not used and dev and regmap are only used
> to set the struct regulator_config fields in mt6311_regulator_init().
> But that won't be necessary if you just remove the
> mt6311_regulator_init() function and move the regulator registration
> logic to mt6311_i2c_probe().
Yes, it should be removed, thanks for the advise.
Henry
>
> Best regards,
> Javier
prev parent reply other threads:[~2015-07-22 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 12:00 [PATCH v2] regulator: mt6311: Add support for MT6311 regulator Henry Chen
2015-07-22 12:00 ` [PATCH v2 1/2] dt-bindings: regulator: mt6311: Add document for Henry Chen
2015-07-22 12:00 ` [PATCH v2 2/2] regulator: mt6311: Add support for mt6311 regulator Henry Chen
2015-07-22 12:50 ` Javier Martinez Canillas
2015-07-22 14:42 ` Henry Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437576174.30329.84.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox