From: HenryC.Chen@mediatek.com (Henry Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator
Date: Fri, 24 Jul 2015 20:59:58 +0800 [thread overview]
Message-ID: <1437742798.30329.100.camel@mtksdaap41> (raw)
In-Reply-To: <CABxcv=kuUbDyzFR2bU7vcvvsqg_yQuqBn5S20=uaH9iBCL_xBQ@mail.gmail.com>
Hi Javier,
On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote:
> Hello Henry,
>
> I believe Mark asked you to use a subject lines reflecting the style
> for the subsystem, so the subject should had been something like:
>
> regulators: mt6311: Add DT binding document
>
> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@mediatek.com> wrote:
> > This patch adds a list of supported regulator names to the devicetree
> > binding documentation for Mediatek MT6311 PMIC.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
>
> I know is in your cover letter, but usually is good to also include a
> history log of the changes for each patch so people know what changed.
> Everything between the '---' and the diff are omitted by tools like
> git am so you can add there. You can use tools like patman that do
> this automatically for you.
>
Ok, got it, I will follow that.
> Also, I said that you could add my Reviewed-by after the node name
> change so you should had carried that. So again:
Sorry, did you mean I need to resent again?
Thanks for advise.
Henry
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Best regards,
> Javier
next prev parent reply other threads:[~2015-07-24 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 5:24 [PATCH v4] regulator: mt6311: Add support for MT6311 regulator Henry Chen
2015-07-24 5:24 ` [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator Henry Chen
2015-07-24 8:32 ` Javier Martinez Canillas
2015-07-24 12:59 ` Henry Chen [this message]
2015-07-24 13:18 ` Javier Martinez Canillas
2015-07-24 5:24 ` [PATCH v4 2/2] regulator: mt6311: Add support " Henry Chen
2015-07-24 8:35 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437742798.30329.100.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox