linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 9/9] arm64/BUG: Show explicit backtrace for WARNs
Date: Fri, 24 Jul 2015 16:37:49 +0100	[thread overview]
Message-ID: <1437752284-14847-10-git-send-email-Dave.Martin@arm.com> (raw)
In-Reply-To: <1437752284-14847-1-git-send-email-Dave.Martin@arm.com>

The generic slowpath WARN implementation prints a backtrace, but
the report_bug() based implementation does not, opting to print the
registers instead which is generally not as useful.

Ideally, report_bug() should be fixed to make the behaviour more
consistent, but in the meantime this patch generates a backtrace
directly from the arm64 backend instead so that this functionality
is not lost with the migration to report_bug().

As a side-effect, the backtrace will be outside the oops end
marker, but that's hard to avoid without modifying generic code.

This patch can go away if report_bug() grows the ability in the
future to generate a backtrace directly or call an arch hook at the
appropriate time.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm64/kernel/traps.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index b10f4bf..bc3dfc5 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -487,6 +487,8 @@ static int bug_handler(struct pt_regs *regs, unsigned int esr)
 		break;
 
 	case BUG_TRAP_TYPE_WARN:
+		/* Ideally, report_bug() should backtrace for us... but no. */
+		dump_backtrace(regs, NULL);
 		break;
 
 	default:
-- 
1.7.10.4

      parent reply	other threads:[~2015-07-24 15:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 15:37 [PATCH v3 0/9] arm64: Use BRK instruction for generic BUG traps Dave Martin
2015-07-24 15:37 ` [PATCH v3 1/9] arm64/debug: Eliminate magic number for size of BRK instruction Dave Martin
2015-07-24 15:37 ` [PATCH v3 2/9] arm64/debug: Mask off all reserved bits from generated ESR values Dave Martin
2015-07-24 15:37 ` [PATCH v3 3/9] arm64/debug: Eliminate magic number from ESR template definition Dave Martin
2015-07-24 15:37 ` [PATCH v3 4/9] arm64/debug: More consistent naming for the BRK ESR template macro Dave Martin
2015-07-24 15:37 ` [PATCH v3 5/9] arm64/debug: Move BRK ESR template macro into <asm/esr.h> Dave Martin
2015-07-24 15:37 ` [PATCH v3 6/9] arm64/debug: Simplify BRK insn opcode declarations Dave Martin
2015-07-24 15:37 ` [PATCH v3 7/9] arm64/debug: Add missing #includes Dave Martin
2015-07-24 15:37 ` [PATCH v3 8/9] arm64/BUG: Use BRK instruction for generic BUG traps Dave Martin
2015-07-24 15:37 ` Dave Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437752284-14847-10-git-send-email-Dave.Martin@arm.com \
    --to=dave.martin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).