linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: scott.shu@mediatek.com (Scott Shu)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/6] soc: Mediatek: Add SCPSYS CPU power domain driver
Date: Sat, 25 Jul 2015 17:13:00 +0800	[thread overview]
Message-ID: <1437815580.4505.14.camel@mtkswgap22> (raw)
In-Reply-To: <20150724055038.GJ18700@pengutronix.de>

On Fri, 2015-07-24 at 07:50 +0200, Sascha Hauer wrote:
> On Fri, Jul 24, 2015 at 10:02:03AM +0800, Scott Shu wrote:
> > On Tue, 2015-06-23 at 07:53 +0200, Sascha Hauer wrote:
> > > Hi Scott,
> > > 
> > > On Fri, Jun 19, 2015 at 02:01:17AM +0800, Scott Shu wrote:
> > > > This adds a CPU power domain driver for the Mediatek SCPSYS unit on
> > > > MT6580.
> > > 
> > > This seems to be support for the very same hardware as I am posting
> > > here:
> > > 
> > > https://lkml.org/lkml/2015/6/22/41
> > > 
> > > We should consolidate this.
> > > 
> > > My driver is currently handles all power domains except the CPUs while
> > > yours handles only the CPUs.
> > > I currently haven't looked whether CPUs can just be part of a power
> > > domain aswell, but if that works this would probably be the way to go.
> > > 
> > > Sascha
> > > 
> > > 
> > Hi Sascga,
> > 
> > We had posted new patch set in following link, but still keep our
> > original framework.
> > http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001498.html
> > 
> > As we mentioned in the new email thread, the SMP operations (smp_boot_secondary)
> > will be executed before registering the scpsys_drv driver, so the CPUs power
> > domain is controlled on arch/arm/mach-$(MACHINE) directory. 
> > 
> > Please kindly provide your comments and suggestion. Thank you very much.
> 
> I think that instead of explaining why have to duplicate the code you
> should rather search for ways how the code can be shared. Yes, we'll
> need a second (early) entry point to the driver. Maybe we even have to
> create the shared code which is then called from the driver and your
> early architecture code.
> You'll probably have to do this separation between early code and
> regular driver code in your driver anyway, since I bet the MT6580 also
> has some power domains which shall be controlled by the regular Linux
> power domain code later. Also we probably could control the CPU power
> domains for the MT8173 in the SCPSYS driver aswell, we just don't have
> to because we use PSCI there. You see we are approaching the same
> problem from two different corners. Let's find a way to share the code.
> 
> Sascha
> 
Hi Sascha,
   Thanks. OK, we move all CPU MTCMOS driver from hotplug.c to
mtk-scpsys.c and the test is passed. Next, we need spend some time to
integrate the code better.

Scott

  reply	other threads:[~2015-07-25  9:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Scott Shu <srv_scott.shu@mediatek.com>
2015-06-18  3:35 ` [PATCH 0/6] This series adds SMP support for the MediaTek MT6580 Scott Shu
2015-06-18  3:35   ` [PATCH 1/6] Document: bindings: DT: Add SMP enable method for MT6580 SoC platform Scott Shu
2015-06-18  3:35   ` [PATCH 2/6] soc: Mediatek: Add SCPSYS CPU power domain driver Scott Shu
2015-06-18  3:35   ` [PATCH 3/6] ARM: mediatek: add smp bringup code for MT6580 Scott Shu
2015-06-18  3:35   ` [PATCH 4/6] ARM: Mediatek: enable GPT6 on boot up to make arch timer working " Scott Shu
2015-06-18  3:35   ` [PATCH 5/6] ARM: dts: mt6580: Add device nodes to the MT6580 dtsi file Scott Shu
2015-06-18  3:35   ` [PATCH 6/6] ARM: dts: mt6580: enable basic SMP bringup for mt6580 Scott Shu
2015-06-18 18:01 ` [RESEND PATCH 0/6] This series adds SMP support for the MediaTek MT6580 Scott Shu
2015-06-18 18:01   ` [RESEND PATCH 1/6] Document: bindings: DT: Add SMP enable method for MT6580 SoC platform Scott Shu
2015-06-29  3:03     ` Yingjoe Chen
2015-07-11 10:38       ` Yingjoe Chen
2015-07-17 22:04         ` Matthias Brugger
2015-06-18 18:01   ` [RESEND PATCH 2/6] soc: Mediatek: Add SCPSYS CPU power domain driver Scott Shu
2015-06-23  5:53     ` Sascha Hauer
2015-07-03  5:58       ` Scott Shu
2015-07-24  2:02       ` Scott Shu
2015-07-24  5:50         ` Sascha Hauer
2015-07-25  9:13           ` Scott Shu [this message]
2015-07-27 10:22             ` Matthias Brugger
2015-06-18 18:01   ` [RESEND PATCH 3/6] ARM: mediatek: add smp bringup code for MT6580 Scott Shu
2015-06-18 18:01   ` [RESEND PATCH 4/6] ARM: Mediatek: enable GPT6 on boot up to make arch timer working " Scott Shu
2015-06-18 18:01   ` [RESEND PATCH 5/6] ARM: dts: mt6580: Add device nodes to the MT6580 dtsi file Scott Shu
2015-06-18 18:01   ` [RESEND PATCH 6/6] ARM: dts: mt6580: enable basic SMP bringup for mt6580 Scott Shu
2015-06-18 18:23   ` [RESEND PATCH 0/6] This series adds SMP support for the MediaTek MT6580 Alexey Klimov
2015-07-24 12:59   ` Matthias Brugger
2015-07-24 13:10     ` Scott Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437815580.4505.14.camel@mtkswgap22 \
    --to=scott.shu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).